Re: [cairo-commit] 3 commits - .gitlab-ci.yml src/cairo-ft-font.c src/cairo-xlib-render-compositor.c

Hi,

On 08.03.2018 22:30, Bryce Harrington wrote:
> New commits:
> commit 5454b85d4bf2f7bea454c940d90255a15517fa3b
> Author: Massimo <[email protected]>
> Date:   Wed Mar 7 14:11:58 2018 -0600
> 
>     bfo#91271 - Fix access of uninitialized memory

Excuse my ignorance, but what is bfo?

> diff --git a/src/cairo-xlib-render-compositor.c b/src/cairo-xlib-render-compositor.c
> index 4352b44c1..4b75109e0 100644
> --- a/src/cairo-xlib-render-compositor.c
> +++ b/src/cairo-xlib-render-compositor.c
> @@ -1830,6 +1830,9 @@ composite_traps (void			*abstract_dst,
>  
>      //X_DEBUG ((display->display, "composite_trapezoids (dst=%x)", (unsigned int) dst->drawable));
>  
> +    if (traps->num_traps == 0)
> +	return CAIRO_STATUS_SUCCESS;
> +
>      if (dst->base.is_clear &&
>  	(op == CAIRO_OPERATOR_OVER || op == CAIRO_OPERATOR_ADD))
>      {

Wouldn't it make more sense to do this somewhere in
cairo-traps-compositor.c so that all users of the trap compositor gets
this and not just the xlib backend?

Also, wouldn't CAIRO_INT_STATUS_NOTHING_TO_DO be more appropriate here?

> commit 7784757b9e271f749b91de27b3472a0151ae2380
> Author: Federico Mena Quintero <[email protected]>
> Date:   Tue Feb 27 17:54:57 2018 -0600
> 
>     Add .gitlab-ci.yml to run the tests automatically

Hm, okay :-/

Cheers,
Uli
-- 
cairo mailing list
[email protected]
https://lists.cairographics.org/mailman/listinfo/cairo