Re: csi-trace does not show help?

Thanks, that's a good find.  I confirmed the misbehavior without this
fix.

I modified the patch a little, to say "strcmp(..) == 0" instead of
"!strcmp()", since the former style seems to be the more common in
cairo/util.

Reviewed-by: Bryce Harrington <[email protected]>

Pushed:
To ssh://git.freedesktop.org/git/cairo
   50a6ad5..33a348d  master -> master


On Sat, Mar 31, 2018 at 09:28:46PM +0900, suzuki toshiya wrote:
> Hi,
> 
> I'm afraid that csi-trace does not show help string correctly,
> because there could be a bug in its command line argument parse.
> 
> Regards,
> mpsuzuki
> 
> diff --git a/util/cairo-script/csi-trace.c b/util/cairo-script/csi-trace.c
> index 52eeade..d64a644 100644
> --- a/util/cairo-script/csi-trace.c
> +++ b/util/cairo-script/csi-trace.c
> @@ -64,10 +64,10 @@ main (int argc, char **argv)
>      csi = cairo_script_interpreter_create ();
> 
>      for (i = 1; i < argc; i++) {
> -        if (strcmp (argv[i], "--version")) {
> +        if (!strcmp (argv[i], "--version")) {
>              printf ("%s: version %s\n", argv[0], __DATE__);
>  	    exit (0);
> -        } else if (strcmp (argv[i], "--help")) {
> +        } else if (!strcmp (argv[i], "--help")) {
>  	    printf ("usage: %s < in > out\n", argv[0]);
>  	    exit (0);
>          }
> 
> -- 
> cairo mailing list
> [email protected]
> https://lists.cairographics.org/mailman/listinfo/cairo
-- 
cairo mailing list
[email protected]
https://lists.cairographics.org/mailman/listinfo/cairo