Re: conditionals for older freetype2 without color font feature
suzuki toshiya <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <[email protected]> |
Dear Bryce, Thank you for prompt review! >> #ifndef FT_HAS_COLOR >> # define FT_HAS_COLOR(x) ( 0 ) >> #endif >> >> in config header is better? > > Offhand I prefer this latter approach, just feels a bit cleaner. Would > you mind respinning your patch with this approach? OK! I would revise and resubmit. Regards, mpsuzuki On 4/3/2018 12:30 PM, Bryce Harrington wrote: > On Tue, Apr 03, 2018 at 10:34:20AM +0900, suzuki toshiya wrote: >> Hi, >> >> FT_HAS_COLOR() macro is unavailable in older freetype2 >> without color font feature. attached is a quick fix. >> >> or, something like >> >> #ifndef FT_HAS_COLOR >> # define FT_HAS_COLOR(x) ( 0 ) >> #endif >> >> in config header is better? > > Offhand I prefer this latter approach, just feels a bit cleaner. Would > you mind respinning your patch with this approach? > >> it seems that fontconfig decided to drop old freetype2, >> but I wish if cairo can provide (limited) support for >> older freetype2. > > Sounds ok, I don't see a problem with doing this. > > Thanks, > Bryce > -- cairo mailing list [email protected] https://lists.cairographics.org/mailman/listinfo/cairo