Re: [PATCH cairo 3/3] snapshot: Don't use extra after it's been freed (CID #220086)

I guess the intended semantics is that the value of *extra_out is
undefined if an error is returned. You are changing this to always NULL
this value instead. Thus, could you also make the earlier NO_MEMORY
return in this function do *extra_out = NULL;?

On 09.06.2018 07:34, Bryce Harrington wrote:
> Coverity ID: 220086
> 
> Signed-off-by: Bryce Harrington <[email protected]>
> ---
>  src/cairo-surface-snapshot.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/cairo-surface-snapshot.c b/src/cairo-surface-snapshot.c
> index c8f3078..0dace49 100644
> --- a/src/cairo-surface-snapshot.c
> +++ b/src/cairo-surface-snapshot.c
> @@ -108,6 +108,7 @@ _cairo_surface_snapshot_acquire_source_image (void                    *abstract_
>      if (unlikely (status)) {
>  	cairo_surface_destroy (extra->target);
>  	free (extra);
> +	extra = NULL;
>      }
>  
>      *extra_out = extra;
> 


-- 
Bruce Schneier can read and understand Perl programs.
-- 
cairo mailing list
[email protected]
https://lists.cairographics.org/mailman/listinfo/cairo