Re: color emoji support broken
Matthias Clasen <[email protected]> Fri, 31 May 2019 08:29:52 -0400
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <CAFwd_vDD+u_pu86EJoKsVFoqOA46Qzo_-cAdx=ymUG+LuQcDFg@mail.gmail.com> |
--===============1546275390== Content-Type: multipart/alternative; boundary="00000000000001b5b5058a2e2df6" --00000000000001b5b5058a2e2df6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks, I later learned that there is already an MR for fixing this issue, by Florian Muellner. On Thu, May 30, 2019 at 11:37 PM suzuki toshiya <[email protected]= > wrote: > According to the commit log when FT_PIXEL_MODE_BGRA was introduced to > FreeType, > > > https://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?id=3D760= d342d37ec9b26420956e3421075d410571b65 > > FT_LOAD_COLOR macro (which we can test its availability by #ifdef) was > introdcued > at the same time. So replacing "#ifdef FT_PIXEL_MODE_BGRA" by "#ifdef > FT_LOAD_COLOR" > would resolve this bug. Just I've submitted a merge request: > > https://gitlab.freedesktop.org/cairo/cairo/merge_requests/25/diffs > > Sincerely I apologize the trouble I caused, and thank to Matthias for > finding > this. I cannot thank you enoughly. > > Regards, > mpsuzuki > > > suzuki toshiya wrote: > > Dear Matthias, > > > > Ahhh, I'm quite sorry. Using "ifdef" is not good to check the > availability of > > FT_PIXEL_MODE_BGRA. > > This is an integer value declared as > > > > typedef enum FT_Pixel_Mode_ > > { > > FT_PIXEL_MODE_NONE =3D 0, > > FT_PIXEL_MODE_MONO, > > FT_PIXEL_MODE_GRAY, > > FT_PIXEL_MODE_GRAY2, > > FT_PIXEL_MODE_GRAY4, > > FT_PIXEL_MODE_LCD, > > FT_PIXEL_MODE_LCD_V, > > FT_PIXEL_MODE_BGRA, > > > > FT_PIXEL_MODE_MAX /* do not remove */ > > > > } FT_Pixel_Mode; > > > > #ifdef is not good. Soon I would post a fix for that, by better > configure script. > > > > Regardss, > > mpsuzuki > > > > suzuki toshiya wrote: > >> Dear Mattias, > >> > >> Maybe this commit? > >> > >> > https://jpn01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fcgit.= freedesktop.org%2Fcairo%2Fcommit%2F%3Fid%3Dc0ed8ce1a111cb9472aef080ac3aa315= 26443f7c&data=3D02%7C01%7Cmpsuzuki%40hiroshima-u.ac.jp%7Cc9dd36ca27c449= 6b21a308d6e5747ea5%7Cc40454ddb2634926868d8e12640d3750%7C1%7C0%7C63694868586= 1037983&sdata=3DVzneUcB3sA50zMDep3IEji2yI4Sw%2BAsv2xK9s92mrow%3D&re= served=3D0 > >> > >> Sorry, please let me know more about your trouble. > >> > >>> This breaks color Emoji support since the freetype headers don't > define this. > >> If so, and if we revert this, following "case FT_PIXEL_MODE_BGRA" woul= d > cause a compilation error? > >> > >> Regards, > >> mpsuzuki > >> > >> On 2019/05/31 2:09, Matthias Clasen wrote: > >>> Some recent commit introduced an > >>> > >>> #ifdef FT_PIXEL_MODE_BGRA > >>> > >>> This breaks color Emoji support since the freetype headers don't > define this. > >>> > >>> Please revert > >>> > -- > cairo mailing list > [email protected] > https://lists.cairographics.org/mailman/listinfo/cairo --00000000000001b5b5058a2e2df6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>Thanks,</div><div><br></div><div>I later learned that= there is already an MR for fixing this issue, by Florian Muellner.<br></di= v></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr= ">On Thu, May 30, 2019 at 11:37 PM suzuki toshiya <<a href=3D"mailto:mps= [email protected]">[email protected]</a>> wrote:<br></div= ><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border= -left:1px solid rgb(204,204,204);padding-left:1ex">According to the commit = log when FT_PIXEL_MODE_BGRA was introduced to FreeType,<br> <br> <a href=3D"https://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/= ?id=3D760d342d37ec9b26420956e3421075d410571b65" rel=3D"noreferrer" target= =3D"_blank">https://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit= /?id=3D760d342d37ec9b26420956e3421075d410571b65</a><br> <br> FT_LOAD_COLOR macro (which we can test its availability by #ifdef) was intr= odcued<br> at the same time. So replacing "#ifdef FT_PIXEL_MODE_BGRA" by &qu= ot;#ifdef FT_LOAD_COLOR"<br> would resolve this bug. Just I've submitted a merge request:<br> <br> <a href=3D"https://gitlab.freedesktop.org/cairo/cairo/merge_requests/25/dif= fs" rel=3D"noreferrer" target=3D"_blank">https://gitlab.freedesktop.org/cai= ro/cairo/merge_requests/25/diffs</a><br> <br> Sincerely I apologize the trouble I caused, and thank to Matthias for findi= ng<br> this. I cannot thank you enoughly.<br> <br> Regards,<br> mpsuzuki<br> <br> <br> suzuki toshiya wrote:<br> > Dear Matthias,<br> > <br> > Ahhh, I'm quite sorry. Using "ifdef" is not good to chec= k the availability of<br> > FT_PIXEL_MODE_BGRA.<br> > This is an integer value declared as<br> > <br> >=C2=A0 =C2=A0typedef enum=C2=A0 FT_Pixel_Mode_<br> >=C2=A0 =C2=A0{<br> >=C2=A0 =C2=A0 =C2=A0FT_PIXEL_MODE_NONE =3D 0,<br> >=C2=A0 =C2=A0 =C2=A0FT_PIXEL_MODE_MONO,<br> >=C2=A0 =C2=A0 =C2=A0FT_PIXEL_MODE_GRAY,<br> >=C2=A0 =C2=A0 =C2=A0FT_PIXEL_MODE_GRAY2,<br> >=C2=A0 =C2=A0 =C2=A0FT_PIXEL_MODE_GRAY4,<br> >=C2=A0 =C2=A0 =C2=A0FT_PIXEL_MODE_LCD,<br> >=C2=A0 =C2=A0 =C2=A0FT_PIXEL_MODE_LCD_V,<br> >=C2=A0 =C2=A0 =C2=A0FT_PIXEL_MODE_BGRA,<br> > <br> >=C2=A0 =C2=A0 =C2=A0FT_PIXEL_MODE_MAX=C2=A0 =C2=A0 =C2=A0 /* do not rem= ove */<br> > <br> >=C2=A0 =C2=A0} FT_Pixel_Mode;<br> > <br> > #ifdef is not good. Soon I would post a fix for that, by better config= ure script.<br> > <br> > Regardss,<br> > mpsuzuki<br> > <br> > suzuki toshiya wrote:<br> >> Dear Mattias,<br> >><br> >> Maybe this commit?<br> >><br> >> <a href=3D"https://jpn01.safelinks.protection.outlook.com/?url=3Dh= ttps%3A%2F%2Fcgit.freedesktop.org%2Fcairo%2Fcommit%2F%3Fid%3Dc0ed8ce1a111cb= 9472aef080ac3aa31526443f7c&amp;data=3D02%7C01%7Cmpsuzuki%40hiroshima-u.= ac.jp%7Cc9dd36ca27c4496b21a308d6e5747ea5%7Cc40454ddb2634926868d8e12640d3750= %7C1%7C0%7C636948685861037983&amp;sdata=3DVzneUcB3sA50zMDep3IEji2yI4Sw%= 2BAsv2xK9s92mrow%3D&amp;reserved=3D0" rel=3D"noreferrer" target=3D"_bla= nk">https://jpn01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fcgi= t.freedesktop.org%2Fcairo%2Fcommit%2F%3Fid%3Dc0ed8ce1a111cb9472aef080ac3aa3= 1526443f7c&amp;data=3D02%7C01%7Cmpsuzuki%40hiroshima-u.ac.jp%7Cc9dd36ca= 27c4496b21a308d6e5747ea5%7Cc40454ddb2634926868d8e12640d3750%7C1%7C0%7C63694= 8685861037983&amp;sdata=3DVzneUcB3sA50zMDep3IEji2yI4Sw%2BAsv2xK9s92mrow= %3D&amp;reserved=3D0</a><br> >><br> >> Sorry, please let me know more about your trouble.<br> >><br> >>> This breaks color Emoji support since the freetype headers don= 't define this.<br> >> If so, and if we revert this, following "case FT_PIXEL_MODE_B= GRA" would cause a compilation error?<br> >><br> >> Regards,<br> >> mpsuzuki<br> >><br> >> On 2019/05/31 2:09, Matthias Clasen wrote:<br> >>> Some recent commit introduced an<br> >>><br> >>> #ifdef FT_PIXEL_MODE_BGRA<br> >>><br> >>> This breaks color Emoji support since the freetype headers don= 't define this.<br> >>><br> >>> Please revert<br> >>><br> -- <br> cairo mailing list<br> <a href=3D"mailto:[email protected]" target=3D"_blank">cairo@cairogra= phics.org</a><br> <a href=3D"https://lists.cairographics.org/mailman/listinfo/cairo" rel=3D"n= oreferrer" target=3D"_blank">https://lists.cairographics.org/mailman/listin= fo/cairo</a></blockquote></div> --00000000000001b5b5058a2e2df6-- --===============1546275390== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline LS0gCmNhaXJvIG1haWxpbmcgbGlzdApjYWlyb0BjYWlyb2dyYXBoaWNzLm9yZwpodHRwczovL2xp c3RzLmNhaXJvZ3JhcGhpY3Mub3JnL21haWxtYW4vbGlzdGluZm8vY2Fpcm8= --===============1546275390==--