Re: Fix a thinko in color glyph support
Matthias Clasen <[email protected]> Sun, 14 Jul 2019 10:44:59 -0400
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <CAFwd_vBEQcqHhx=Wep=twsDpmLV4VYr-ae5Z8fy41PWVWgZn4g@mail.gmail.com> |
--===============0990481595== Content-Type: multipart/alternative; boundary="000000000000bc3e25058da53034" --000000000000bc3e25058da53034 Content-Type: text/plain; charset="UTF-8" On Fri, May 31, 2019 at 9:59 AM Matthias Clasen <[email protected]> wrote: > I've spent some time tracking down a GTK+ / Pango crash ( > https://gitlab.gnome.org/GNOME/pango/issues/346 ). > > Turns out that there was a thinko in our original color glyph patch. We > can't modify the passed-in text. > > Here is a quick fix: > > > https://github.com/matthiasclasen/cairo/commit/79ad01724161502e8d9d2bd384ff1f0174e5df6e > > This probably needs to go into a stable cairo branch too. > Hi, two months on, this is still not in git. It is a very easy memory corruption patch. We ship the patch in Fedora, but I would prefer to not rely on distros to pick through the rubble. Can we get this merged, please ? --000000000000bc3e25058da53034 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><br></div>On Fri, May 31, 2019 at 9:59 AM= Matthias Clasen <<a href=3D"mailto:[email protected]">matthias.= [email protected]</a>> wrote:<br><div class=3D"gmail_quote"><blockquote c= lass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px soli= d rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div>I've spent s= ome time tracking down a GTK+ / Pango crash ( <a href=3D"https://gitlab.gno= me.org/GNOME/pango/issues/346" target=3D"_blank">https://gitlab.gnome.org/G= NOME/pango/issues/346</a> ).</div><div><br></div><div>Turns out that there = was a thinko in our original color glyph patch. We</div><div>can't modi= fy the passed-in text.</div><div><br></div><div>Here is a quick fix:<br></d= iv><div><br></div><div><a href=3D"https://github.com/matthiasclasen/cairo/c= ommit/79ad01724161502e8d9d2bd384ff1f0174e5df6e" target=3D"_blank">https://g= ithub.com/matthiasclasen/cairo/commit/79ad01724161502e8d9d2bd384ff1f0174e5d= f6e</a></div><div><br></div><div>This probably needs to go into a stable ca= iro branch too.<br></div></div></blockquote><div><br></div><div>Hi, two mon= ths on, this is still not in git. It is a very easy memory corruption patch= .</div><div>We ship the patch in Fedora, but I would prefer to not rely on = distros to pick through</div><div>the rubble. Can we get this merged, pleas= e ?<br></div></div></div> --000000000000bc3e25058da53034-- --===============0990481595== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline LS0gCmNhaXJvIG1haWxpbmcgbGlzdApjYWlyb0BjYWlyb2dyYXBoaWNzLm9yZwpodHRwczovL2xp c3RzLmNhaXJvZ3JhcGhpY3Mub3JnL21haWxtYW4vbGlzdGluZm8vY2Fpcm8= --===============0990481595==--