Re: [PATCH 1/3] Windows: Use DOS path separators in Makefile

Dave Yeo <[email protected]> Fri, 20 Dec 2019 09:33:35 -0800

Newsgroups	gmane.comp.lib.cairo
Message-ID	<[email protected]>

On 12/20/19 04:39 AM, Simon Richter wrote:
>  build/Makefile.win32.common | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/build/Makefile.win32.common b/build/Makefile.win32.common
> index 7d7e9735f..093b0223a 100644
> --- a/build/Makefile.win32.common
> +++ b/build/Makefile.win32.common
> @@ -24,32 +24,32 @@ CFG_LDFLAGS :=
>  endif
>
>  ifeq ($(PIXMAN_PATH),)
> -PIXMAN_PATH := $(top_builddir)/../pixman
> +PIXMAN_PATH := $(top_builddir)\..\pixman
>  endif

Does Windows still not understand / as a path separator?
What happens if someone invokes this with SHELL=sh.exe or 
MAKESHELL=sh.exe? Perhaps the \ should be escaped like \\ ?
I don't know Windows too well but on OS/2 which is DOSish, these are 
considerations.
Dave
-- 
cairo mailing list
[email protected]
https://lists.cairographics.org/mailman/listinfo/cairo