[patch] FOX 1.7.84 -> 1.7.85: Regression in FXObject.h
"Jason E. Hale" <[email protected]> Sat, 24 Aug 2024 04:52:22 -0400
| Newsgroups | gmane.comp.lib.fox-toolkit.user |
|---|---|
| Message-ID | <CAJE75NFrWfZUx=ifHt2GrzbwPrRSG9DaHLP3Xa+o2DCZwPFTTw@mail.gmail.com> |
When FXObject.h is simply included, builds fail in projects such as
gogglesmm [1]. In 1.7.85, the inclusion of FXMetaClass.h was removed
from FXObject.h, causing the compiler to no longer recognize
FXSelector as a type in the FX namespace.
Example error from trying to build gogglesmm with LLVM 18.1.6 on
FreeBSD-CURRENT:
/usr/local/include/fox-1.7/FXObject.h:135:3: fatal error: no type
named 'FXSelector' in namespace 'FX'
135 | FXDECLARE(FXObject)
| ^~~~~~~~~~~~~~~~~~~
/usr/local/include/fox-1.7/FXObject.h:50:28: note: expanded from macro
'FXDECLARE'
50 | struct FXMapEntry { FX::FXSelector keylo; FX::FXSelector
keyhi; long (classname::* func)(FX::FXObject*,FX::FXSelector,void*);
}; \
| ~~~~^
I've attached a patch to fix the issue and in case the ML scrubs
attachments, the patch can also be found here:
https://people.freebsd.org/~jhale/patches/fox-1.7.85-include-FXObject.h.diff
[1] https://github.com/gogglesmm/gogglesmm
_______________________________________________
Foxgui-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/foxgui-users
fox-1.7.85-include-FXObject.h.diff
(text/x-patch, 208 B)
--- include/FXObject.h.orig 2024-06-30 15:47:37 UTC
+++ include/FXObject.h
@@ -25,6 +25,10 @@
#include "FXCallback.h"
#endif
+#ifndef FXMETACLASS_H
+#include "FXMetaClass.h"
+#endif
+
namespace FX {