Re: [PATCH] tests: Handle system-wide tunables in rseq tests

On 2026-07-03 05:14, Yury Khrustalev wrote:
>>
>> I seem to recall in the past, I've just added the one test to both lists
>> and it seemed to work.  It might depend on which two lists you're adding
>> it to.
> 
> The elf/tst-tunconf1 test is added to both tests-internal and tests-container
> in elf/Makefile. This test also has 'elf/tst-tunconf1.root' folder for
> the container and it uses custom tunables. I think you could do the same
> with the rseq tests.

I thought I was doing something wrong but I get the same behavior with 
other container tests, when I try to run a single test like so:

   $ ../configure --prefix=/usr
   $ make -j$(nproc)
   $ make test t=elf/tst-tunconf1

The testroot.pristine is not created in the build dir and the test fails 
with:

FAIL: elf/tst-tunconf1
original exit status 1
error: test-container.c:835: Cannot create testroot lock.


If I run the full 'elf' testsuite:

   $ make subdirs=elf check -j$(nproc)

Then the testroot.pristine is created, all the tests succeed and I can 
then run the single test successfully. I tried finding the missing 
dependency in the Makefiles but couldn't quite figure it out.

Anyway, other than that it works, so do you prefer a second version of 
the patch using tests-container for the rseq tests or is this simple one 
that only adds the reporting good enough?

Thanks,

Michael