Re: [PATCH] tests: Handle system-wide tunables in rseq tests

On Fri, Jul 03, 2026 at 11:13:45AM -0400, Michael Jeanson wrote:
> On 2026-07-03 05:14, Yury Khrustalev wrote:
> > > 
> > > I seem to recall in the past, I've just added the one test to both lists
> > > and it seemed to work.  It might depend on which two lists you're adding
> > > it to.
> > 
> > The elf/tst-tunconf1 test is added to both tests-internal and tests-container
> > in elf/Makefile. This test also has 'elf/tst-tunconf1.root' folder for
> > the container and it uses custom tunables. I think you could do the same
> > with the rseq tests.
> 
> I thought I was doing something wrong but I get the same behavior with other
> container tests, when I try to run a single test like so:
> 
>   $ ../configure --prefix=/usr
>   $ make -j$(nproc)
>   $ make test t=elf/tst-tunconf1
> 
> The testroot.pristine is not created in the build dir and the test fails
> with:
> 
> FAIL: elf/tst-tunconf1
> original exit status 1
> error: test-container.c:835: Cannot create testroot lock.

I also encountered this problem. You can generate testroot using this
command (run inside the build folder):

  make $(pwd)/testroot.pristine/install.stamp

> If I run the full 'elf' testsuite:
> 
>   $ make subdirs=elf check -j$(nproc)
> 
> Then the testroot.pristine is created, all the tests succeed and I can then
> run the single test successfully. I tried finding the missing dependency in
> the Makefiles but couldn't quite figure it out.

I agree it would be nice to fix makefile dependencies, but I don't know
an easy way to do that.

> Anyway, other than that it works, so do you prefer a second version of the
> patch using tests-container for the rseq tests or is this simple one that
> only adds the reporting good enough?

I think it's best to use test-container for the rseq tests so that we
can fully control the test environment for them.

Thanks,
Yury