Re: [PATCH v2 07/13] Add OPEN_TREE_NAMESPACE and FSMOUNT_NAMESPACE to sys/mount.h

Adhemerval Zanella Netto <[email protected]> Fri, 3 Jul 2026 15:01:47 -0300

Newsgroups	gmane.comp.lib.glibc.alpha
Organization	Linaro
Message-ID	<[email protected]>


On 03/07/26 14:44, Florian Weimer wrote:
>>  /* mount attributes used on fsmount.  */
>>  #define MOUNT_ATTR_RDONLY       0x00000001 /* Mount read-only.  */
>> @@ -267,6 +269,10 @@ enum fsconfig_command
>>  #ifndef OPEN_TREE_CLONE
>>  # define OPEN_TREE_CLONE    1 /* Clone the target tree and attach the clone */
>>  #endif
>> +#ifndef OPEN_TREE_NAMESPACE
>> +# define OPEN_TREE_NAMESPACE 2 /* Clone the target tree into a new mount
>> +				  namespace */
>> +#endif
> I would use
> 
> #define OPEN_TREE_NAMESPACE (1 << 1)
> 
> without the #ifdef.  We added the #ifdef only because the referenced
> commit changed the token sequence for OPEN_TREE_CLONE.

Ack.