Re: [PATCH v2 09/13] netinet/tcp.h: Sync with Linux 6.15 and fix struct tcp_info tail

Adhemerval Zanella Netto <[email protected]>
Newsgroups gmane.comp.lib.glibc.alpha
Organization Linaro
Message-ID <[email protected]>

On 03/07/26 15:07, Florian Weimer wrote:
> * Adhemerval Zanella:
> 
>> Add the TCP_RTO_MAX_MS and TCP_RTO_MIN_US socket options (commit
>> 54a378f43425085d0684679d99735696b69165bc, Linux 6.15) and TCP_DELACK_MAX_US
>> (commit 9552f90835ef3552d0af327e48dc360717777d62, Linux 6.15).
>>
>> Commit 7e46c2aae47d3284d4eb0845ddcc3951e987d681 synced the accurate ECN
>> additions but encoded the trailing bitfield word of struct tcp_info
>> incorrectly as two uint16_t fields (tcpi_accecn_fail_mode and
>> tcpi_accecn_opt_seen), omitting tcpi_ecn_mode and tcpi_options2.  Restore
>> the kernel layout:
>>
>>   uint32_t tcpi_ecn_mode:2,
>> 	   tcpi_accecn_opt_seen:2,
>> 	   tcpi_accecn_fail_mode:4,
>> 	   tcpi_options2:24;
> 
> Does this need a bug report?  This should probably be backported to
> 2.43.

Good question, I will open one anyway.

> 
> Rest looks okay.
> 
> Reviewed-by: Florian Weimer <[email protected]>
> 
> Thanks,
> Florian
>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.