[PATCH] Makefile: Depend on elf/subdir_lib only if $(subdirs) has elf

"H.J. Lu" <[email protected]>
Newsgroups gmane.comp.lib.glibc.alpha
Message-ID <CAMe9rOpXor=+KZHHSkQ8thrufF5gLJj9XzbayXZZGZXoPYy8gQ@mail.gmail.com>
commit 7cac99621e9601f916121bcaa9b7734a2e4c2529
Author: Adhemerval Zanella <[email protected]>
Date:   Wed Jun 10 16:26:15 2026 -0300

    Makefile: Run the subdirectory recursion in parallel

added:

$(elf-objpfx)ld.so $(elf-objpfx)sofini.os $(elf-objpfx)interp.os: \
  | elf/subdir_lib ;

which doesn't work with

$ make check -jN subdirs=DIR

where DIR doesn't have elf.  Add such rule only if $(subdirs) has elf.
This fixes BZ #34355.

-- 
H.J.
0001-Makefile-Depend-on-elf-subdir_lib-only-if-subdirs-ha.patch (text/x-patch, 1.4 KB)
From 53502db065395907835a86a023872ec5c699732e Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <[email protected]>
Date: Mon, 6 Jul 2026 08:51:10 +0800
Subject: [PATCH] Makefile: Depend on elf/subdir_lib only if $(subdirs) has elf

commit 7cac99621e9601f916121bcaa9b7734a2e4c2529
Author: Adhemerval Zanella <[email protected]>
Date:   Wed Jun 10 16:26:15 2026 -0300

    Makefile: Run the subdirectory recursion in parallel

added:

$(elf-objpfx)ld.so $(elf-objpfx)sofini.os $(elf-objpfx)interp.os: \
  | elf/subdir_lib ;

which doesn't work with

$ make check -jN subdirs=DIR

where DIR doesn't have elf.  Add such rule only if $(subdirs) has elf.
This fixes BZ #34355.

Signed-off-by: H.J. Lu <[email protected]>
---
 Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Makefile b/Makefile
index 54de425e9e..a6aabca691 100644
--- a/Makefile
+++ b/Makefile
@@ -614,8 +614,10 @@ ifeq (yes,$(build-shared))
 # builds them.  The explicit empty recipe (';') is required, a
 # prerequisite-only rule would send make on an implicitrule search and
 # have this level compile them itself with the wrong context.
+ifneq (,$(filter elf,$(subdirs)))
 $(elf-objpfx)ld.so $(elf-objpfx)sofini.os $(elf-objpfx)interp.os: \
   | elf/subdir_lib ;
+endif
 ifneq (,$(filter sunrpc,$(subdirs)))
 # Makerules explicit adds librpc_compat_pic.a as a dependency of
 # libc_pic.a.
-- 
2.55.0
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.