Re: [PATCH 5/8] elf: Emit tunconf "not recognized" warning on stderr
Adhemerval Zanella Netto <[email protected]>
| Newsgroups | gmane.comp.lib.glibc.alpha |
|---|---|
| Organization | Linaro |
| Message-ID | <[email protected]> |
On 08/07/26 23:20, DJ Delorie wrote: > > Adhemerval Zanella <[email protected]> writes: >> For consistency with other errors. > > I did it this way so it *wasn't* an error, just a warning. We don't > have warning_at_line(). I couldn't think of a good reason to limit the > cache only to tunables that the current version of ldconfig knows about, > so I didn't. This way we can support multiple versions of glibc and > evern non-glibc tunables (assuming the application had a way to get to > them). Fair enough, ignoring unknown tunable should be ok for cache generation. I withdraw this patch. > >> diff --git a/elf/tunconf.c b/elf/tunconf.c > >> - printf ("%s:%d: Warning: tunable %s not recognized.\n", >> - filename, lineno, name); >> + error_at_line (0, 0, filename, lineno, >> + "Warning: tunable %s not recognized", name); >