Re: [PATCH v7 1/1] ldconfig: add --install option
DJ Delorie <[email protected]>
| Newsgroups | gmane.comp.lib.glibc.alpha |
|---|---|
| Message-ID | <[email protected]> |
Florian Weimer <[email protected]> writes: >> It's small, well-separated, and doesnt affect existing operation. So yeah, I >> dont see any problems. >> >> Mostly I don't fully understand the use case yet, but that may be a problem >> behind *my* keyboard and is irrelevant for the release... >> Is the source file supposed to come from the live system (since it needs to >> know all installed libraries)? or from some other magic source? > > I think this needs a NEWS entry. The dynamic linker keeps > /etc/ld.so.cache mapped continuously, so if you use cp to copy the > cache, it's more likely that it will lead to crashes because the size of > the mapping does not match the file contents. > > Using ldconfig --install avoids that because doesn't overwrite the file > in place. Using rsync (without --inplace) or GNU install would be fine, > too. Andreas, Does this answer your concerns? Is it still OK to push, or do you now request changes or a NEWS entry?