Re: [PATCH v2] Add RWF_NOSIGNAL from Linux 6.18 to bits/uio-ext.h

On 16/07/26 18:56, Carlos O'Donell wrote:
> On 7/6/26 10:18 AM, Adhemerval Zanella wrote:
>> It was added by commit db2ab24a341ce89351a1bede37a96a3e3ce1726a.
> 
> LGTM. But I have one question below.
> 
> Reviewed-by: Carlos O'Donell <[email protected]>
> 
>> ---
>>   misc/tst-preadvwritev2-common.c        | 2 +-
>>   sysdeps/unix/sysv/linux/bits/uio-ext.h | 1 +
>>   2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/misc/tst-preadvwritev2-common.c b/misc/tst-preadvwritev2-common.c
>> index 00c51753247..a7705c06e0e 100644
>> --- a/misc/tst-preadvwritev2-common.c
>> +++ b/misc/tst-preadvwritev2-common.c
>> @@ -45,7 +45,7 @@
>>   #endif
>>   #define RWF_SUPPORTED    (RWF_HIPRI | RWF_DSYNC | RWF_SYNC | RWF_NOWAIT \
>>                | RWF_APPEND | RWF_NOAPPEND | RWF_ATOMIC \
>> -             | RWF_DONTCACHE)
>> +             | RWF_DONTCACHE | RWF_NOSIGNAL)
> 
> This is OK.
> 
> But we don't do this:
> 
> #ifndef RWF_NOSIGNAL
> # define RWF_NOSIGNAL 0
> #endif
> 
> Is it because we redefine these constants now in uio-ext.h?

Because I have not build for Hurd, the snippet is require to build correctly.
I will add them.

> 
> I did a quick check and that appears to be the case.
> 
> Were all the previous guards put in place when we used to use the kernel values directly
> or when we did not consistently update the constant and the test?
> > Can we remove all the guards in the test (another cleanup)?
> 
>>     /* Generic uio_lim.h does not define IOV_MAX.  */
>>   #ifndef IOV_MAX
>> diff --git a/sysdeps/unix/sysv/linux/bits/uio-ext.h b/sysdeps/unix/sysv/linux/bits/uio-ext.h
>> index 49c8734228c..5c842b25c92 100644
>> --- a/sysdeps/unix/sysv/linux/bits/uio-ext.h
>> +++ b/sysdeps/unix/sysv/linux/bits/uio-ext.h
>> @@ -51,6 +51,7 @@ extern ssize_t process_vm_writev (pid_t __pid, const struct iovec *__lvec,
>>   #define RWF_ATOMIC    0x00000040 /* Write is to be issued with torn-write
>>                         prevention.  */
>>   #define RWF_DONTCACHE    0x00000080 /* Uncached buffered IO.  */
>> +#define RWF_NOSIGNAL    0x00000100 /* Do not generate SIGPIPE on error.  */
> 
> OK.
> 
> Matches:
> 
> commit db2ab24a341ce89351a1bede37a96a3e3ce1726a
> Author: Lauri Vasama <[email protected]>
> Date:   Wed Aug 27 16:39:00 2025 +0300
> 
>     Add RWF_NOSIGNAL flag for pwritev2
> 
>>     __END_DECLS
>>   
> 
>