[PATCH] tests: Align THP tests to the 32MB huge-page size
Wilco Dijkstra <[email protected]>
| Newsgroups | gmane.comp.lib.glibc.alpha |
|---|---|
| Message-ID | <PAWPR08MB8982FC27298922C3528B573783C12@PAWPR08MB8982.eurprd08.prod.outlook.com> |
Hi Xi, I agree we should avoid creating even more target specific defines and errors. grep THP_PAGE_SIZE -R * sysdeps/unix/sysv/linux/Makefile:THP-PAGE-SIZE-CFLAGS = -DTHP_PAGE_SIZE=$(THP-PAGE-SIZE) sysdeps/unix/sysv/linux/tst-thp-size.S: .space 2 * THP_PAGE_SIZE It's not really a THP page size as its only use is to force a large .text section. So I'm not sure we even need a define for this, let alone making it target specific - it could just be a fixed amount. Assuming we keep the 32MB limit on THP pages, 64MB should be fine for all targets. Cheers, Wilco