Re: [PATCH v2] elf: Make string tunables startup-only

On Jul 30 2026, Adhemerval Zanella Netto wrote:

> On 30/07/26 03:41, Andreas Schwab wrote:
>> On Jul 29 2026, Adhemerval Zanella wrote:
>> 
>>> +/* Set by __tunable_seal_strings once the values of the string tunables are
>>> +   no longer valid.  */
>>> +static bool tunables_strings_sealed attribute_relro;
>>> +
>>> +static void __attribute__ ((noreturn))
>>> +tunable_sealed_error (const tunable_t *cur, const char *action)
>>> +{
>>> +  _dl_fatal_printf ("Fatal glibc error: %s: string tunable %s after "
>>> +		    "process initialization\n", cur->name, action);
>> 
>> I think this should be presented as an internal error, ie. it is not due
>> to some kind of resource constraint, but a glibc programming error.
>> 
>
> Maybe something like:
>
>   "internal error: %s: string tunable %s after process initialization\n"
>
> ?

This looks ok.

-- 
Andreas Schwab, SUSE Labs, [email protected]
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."