Re: [PATCH] alpha: Fix fts and fts64 ABI mismatch

On 04/08/26 14:13, Magnus Lindholm wrote:
> Hi,
> 
> On Tue, Aug 4, 2026 at 3:50 PM Adhemerval Zanella Netto
> <[email protected]> wrote:
> 
>>>
>>> Only share the implementations when both the offset and inode types
>>> match.  Add Alpha sysdeps wrappers so that separate fts and fts64
>>> implementations are built.
>>
>> It is not clear to me why you need alpha-specific one after
>> b9a2dea54abd1c5db9773a92c97dd3202bbaec62.
>>
> 
> Thanks for pointing that out, Matt also noticed this.
> 
> You are right: after b9a2dea54abd ("Remove fts64 compat handling from
> sysdeps"), both io/fts.c and io/fts64.c are built directly, so the
> Alpha-specific wrappers are not needed. I had overlooked that change.
> 
> I will send a v2 which drops the two Alpha sysdeps files and keeps only
> the generic changes to io/fts.c and io/fts64.c, making the
> implementation sharing conditional on both the offset and inode types
> matching.
Right, I would also recommend to double-check if this does not break any
other ABI since the code is not generic.