Re: [PATCH v4 02/14] aarch64: Enable internal use of memory protection keys

On Thu, Jul 30, 2026 at 06:31:04PM -0300, Adhemerval Zanella Netto wrote:
> 
> On 30/07/26 10:42, Yury Khrustalev wrote:
> > * Florian
> > 
> > On Mon, Mar 17, 2025 at 09:24:10AM -0300, Adhemerval Zanella Netto wrote:
> >>
> >> On 02/02/25 18:12, Florian Weimer wrote:
> >>> This adds hidden prototypes to align with commit 7e21a65c58cc91b3ba
> >>> ("misc: Enable internal use of memory protection keys").
> >>
> >> LGTM, thanks.
> >>
> >> Reviewed-by: Adhemerval Zanella  <[email protected]>
> > 
> > What happened to this patch? It was approved but I don't think it was
> > merged?
> > 
> 
> I think because Florian has not reply to some points I have raised [1] in the
> last revision rounds, nor I have finished reviewing this patchset as a whole.
> 
> I am not sure if Florian is planning to send a new version, and I still not
> quite sure if the attack to internal glibc metadata [2][3] are really worth
> adding the extra complexity and performance hit on some operations.
> 
> [1] https://sourceware.org/pipermail/libc-alpha/2025-March/165293.html
> [2] https://github.com/nobodyisnobody/docs/blob/main/code.execution.on.last.libc/README.md
> [3] https://m101.github.io/binholic/2017/05/20/notes-on-abusing-exit-handlers.html

Fair point. Shall I mark this patch as Rejected in Patchwork then? It's
currently Accepted but not merged.

Thanks,
Yury