Re: [PATCH] elf: Remove __glibc_likely from _dl_sort_maps
Wilco Dijkstra <[email protected]>
| Newsgroups | gmane.comp.lib.glibc.alpha |
|---|---|
| Message-ID | <PAWPR08MB89828C4D3056BC0A3FDBB32283A72@PAWPR08MB8982.eurprd08.prod.outlook.com> |
Hi Litenglong, > _dl_sort_maps is only called during shared object loading and > unloading, not on any hot path. The branch predictor hint has no > measurable benefit, and removing it simplifies the code and avoids > future maintenance when the default algorithm changes. > > Suggested-by: Wilco Dijkstra <[email protected]> LGTM. Reviewed-by: Wilco Dijkstra <[email protected]> Cheers, Wilco