Re: [PATCH v3 1/3] iconvdata: SHIFT_JISX0213 decoding lacks pending character reset (CVE-2026-77117)

Carlos O'Donell <[email protected]>
Newsgroups gmane.comp.lib.glibc.alpha
Organization Red Hat, LLC.
Message-ID <[email protected]>
On 8/27/26 7:57 AM, Florian Weimer wrote:
> This fixes bug 34556.

LGTM. And does what I expect in this case.

Reviewed-by: Carlos O'Donell <[email protected]>

> ---
> v3: Split into separate bugs with distinct CVE IDs, as requested.
>   iconvdata/shift_jisx0213.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/iconvdata/shift_jisx0213.c b/iconvdata/shift_jisx0213.c
> index 61c9c3ce6d..e9179f605e 100644
> --- a/iconvdata/shift_jisx0213.c
> +++ b/iconvdata/shift_jisx0213.c
> @@ -226,6 +226,9 @@
>   	    STANDARD_FROM_LOOP_ERR_HANDLER (1);				      \
>   	  }								      \
>         }									      \
> +    else 								      \
> +      /* There was a pending character.  Clear it.  */			      \
> +      *statep = 0;							      \
>   									      \
>       put32 (outptr, ch);							      \
>       outptr += 4;							      \
> 
> base-commit: b090cf226ff65b913e41536f1f573f500855615c


-- 
Cheers,
Carlos.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.