Re: [PATCH] Add check-symbol-verion.awk
Sam James <[email protected]>
| Newsgroups | gmane.comp.lib.glibc.alpha |
|---|---|
| Organization | Gentoo |
| Message-ID | <[email protected]> |
"H.J. Lu" <[email protected]> writes: > On Wed, Aug 26, 2026 at 5:18 PM Sam James <[email protected]> wrote: >> >> Sam James <[email protected]> writes: >> >> > "H.J. Lu" <[email protected]> writes: >> > >> >> commit 6deadd4eb6ab4f59d116b2d7ad97be0d0848cb7f >> >> Author: Adhemerval Zanella <[email protected]> >> >> Date: Wed Oct 8 10:55:05 2025 -0300 >> >> >> >> didn't remove sysdeps/m68k/m680x0/fpu/w_fmod_compat.c. As the result, >> >> due to a linker bug: >> >> >> >> https://sourceware.org/bugzilla/show_bug.cgi?id=34550 >> >> >> >> there were 2 default versions of fmod in m68k libm: >> >> >> >> 996: 0001433c 174 FUNC WEAK DEFAULT 12 fmod@@GLIBC_2.0 >> >> 997: 000307d4 214 FUNC GLOBAL DEFAULT 12 fmod@@GLIBC_2.43 >> >> >> >> Add check-symbol-verion.awk to verify that versioned symbols only have >> >> one default version in dynamic symbol table. >> > >> > Good idea. >> > >> > Reviewed-by: Sam James <[email protected]> >> >> Maybe test it on build-many-glibcs.py first in case of fallout. I also >> assume it found the m68k problem if the fix is reverted. > > Both are correct. Here is the patch I am checking in. > > Thanks. I've pushed it to 2.44 branch as well because I think any failures are a serious issue we should look at.
signature.asc
(application/pgp-signature, 418 B)
-----BEGIN PGP SIGNATURE----- iQEBBAEWCgCpFiEEJaa7iN2bdkxrVUHCc4QJ9SDfkZAFAmqS0nIbFIAAAAAABAAO bWFudTIsMi41KzEuMTIsMiwyXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25z Lm9wZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQyNUE2QkI4OEREOUI3NjRDNkI1NTQx QzI3Mzg0MDlGNTIwREY5MTkwDxxzYW1AZ2VudG9vLm9yZwAKCRBzhAn1IN+RkFXW AQD9TxfqsIrSDG1n2GSu9KahsFfrdJmW4+5/V61PDvN7XwD+M7igc3mgpdxLCdpG jXD0518RmysOfkCi7W6LTHlICAk= =8CZF -----END PGP SIGNATURE-----