[glibc] riscv: Fix RV32 libthread_db THREAD_SELF register layout
Peter Bergner via Glibc-cvs <[email protected]> Wed, 24 Jun 2026 17:54:13 +0000 (GMT)
| Newsgroups | gmane.comp.lib.glibc.cvs |
|---|---|
| Message-ID | <[email protected]> |
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a014af39fd36151b204dfb6e91bef0788272c811 commit a014af39fd36151b204dfb6e91bef0788272c811 Author: Shengwen Cheng <[email protected]> Date: Wed Jun 24 17:52:49 2026 +0000 riscv: Fix RV32 libthread_db THREAD_SELF register layout The RISC-V libthread_db THREAD_SELF descriptor currently assumes 64-bit general-register slots: REGISTER (64, 64, 4 * 8, ...) That is correct for RV64, where tp/x4 is at byte offset 4 * 8 in the general register set. On RV32, general-register slots are 32-bit wide, so tp/x4 is at byte offset 4 * 4. Using the RV64 layout on RV32 makes libthread_db read the wrong thread pointer value and prevents GDB from enabling pthread-aware thread debugging. Use a helper macro to pass the RISC-V register size into the DB_THREAD_SELF definition. Signed-off-by: Shengwen Cheng <[email protected]> Reviewed-by: Peter Bergner <[email protected]> Diff: --- sysdeps/riscv/nptl/tls.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sysdeps/riscv/nptl/tls.h b/sysdeps/riscv/nptl/tls.h index b2e0f3c249..1e46e93669 100644 --- a/sysdeps/riscv/nptl/tls.h +++ b/sysdeps/riscv/nptl/tls.h @@ -96,8 +96,9 @@ typedef struct /* Informs libthread_db that the thread pointer is register 4, which is used * to know how to do THREAD_SELF. */ -# define DB_THREAD_SELF \ - REGISTER (64, 64, 4 * 8, - TLS_TCB_OFFSET - TLS_PRE_TCB_SIZE) +# define DB_THREAD_SELF_REGISTER(bits) \ + REGISTER (bits, bits, 4 * bits / 8, - TLS_TCB_OFFSET - TLS_PRE_TCB_SIZE) +# define DB_THREAD_SELF DB_THREAD_SELF_REGISTER (__riscv_xlen) /* Access to data in the thread descriptor is easy. */ # include <tcb-access.h>