[glibc] Makerules: Only install the ABI lib-names header from the top level (BZ 34439)
Adhemerval Zanella via Glibc-cvs <[email protected]>
| Newsgroups | gmane.comp.lib.glibc.cvs |
|---|---|
| Message-ID | <[email protected]> |
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=82c0a96b8e63005a49ba52ddb21993811030613f commit 82c0a96b8e63005a49ba52ddb21993811030613f Author: Rudi Heitbaum <[email protected]> Date: Thu Aug 6 14:07:56 2026 -0300 Makerules: Only install the ABI lib-names header from the top level (BZ 34439) The $(inst_includedir)/%.h install rules exist only where $(headers) is non-empty, so in a subdir without headers (e.g. csu) the prerequisite added on install-others-nosubdir has no rule. It only worked because .NOTPARALLEL made the top level install the header first, which the parallel subdir recursion no longer guarantees. Reviewed-by: Sam James <[email protected]> Diff: --- Makerules | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Makerules b/Makerules index cef30974f1..dfe66b7fa6 100644 --- a/Makerules +++ b/Makerules @@ -312,7 +312,12 @@ lib-names-h-abi = gnu/lib-names-$(default-abi).h lib-names-stmp-abi = gnu/lib-names-$(default-abi).stmp before-compile += $(common-objpfx)$(lib-names-h-abi) common-generated += gnu/lib-names.h +# The $(inst_includedir)/%.h install rules are defined only where $(headers) +# is non-empty, and with parallel subdir recursion a subdir without headers +# (e.g. csu) may run before the top level has installed the header. +ifndef subdir install-others-nosubdir: $(inst_includedir)/$(lib-names-h-abi) +endif $(common-objpfx)gnu/lib-names.h: $(make-target-directory) { \