[glibc/release/2.44/master] Makerules: Only install the ABI lib-names header from the top level (BZ 34439)
Adhemerval Zanella via Glibc-cvs <[email protected]>
| Newsgroups | gmane.comp.lib.glibc.cvs |
|---|---|
| Message-ID | <[email protected]> |
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=45b8a13c48da92bc5dd6fe102011391dd6847862 commit 45b8a13c48da92bc5dd6fe102011391dd6847862 Author: Rudi Heitbaum <[email protected]> Date: Thu Aug 6 14:07:56 2026 -0300 Makerules: Only install the ABI lib-names header from the top level (BZ 34439) The $(inst_includedir)/%.h install rules exist only where $(headers) is non-empty, so in a subdir without headers (e.g. csu) the prerequisite added on install-others-nosubdir has no rule. It only worked because .NOTPARALLEL made the top level install the header first, which the parallel subdir recursion no longer guarantees. Reviewed-by: Sam James <[email protected]> (cherry picked from commit 82c0a96b8e63005a49ba52ddb21993811030613f) Diff: --- Makerules | 5 +++++ NEWS | 2 ++ 2 files changed, 7 insertions(+) diff --git a/Makerules b/Makerules index cef30974f1..dfe66b7fa6 100644 --- a/Makerules +++ b/Makerules @@ -312,7 +312,12 @@ lib-names-h-abi = gnu/lib-names-$(default-abi).h lib-names-stmp-abi = gnu/lib-names-$(default-abi).stmp before-compile += $(common-objpfx)$(lib-names-h-abi) common-generated += gnu/lib-names.h +# The $(inst_includedir)/%.h install rules are defined only where $(headers) +# is non-empty, and with parallel subdir recursion a subdir without headers +# (e.g. csu) may run before the top level has installed the header. +ifndef subdir install-others-nosubdir: $(inst_includedir)/$(lib-names-h-abi) +endif $(common-objpfx)gnu/lib-names.h: $(make-target-directory) { \ diff --git a/NEWS b/NEWS index ee292ff6c9..d0ef2d3e9a 100644 --- a/NEWS +++ b/NEWS @@ -13,6 +13,8 @@ The following bugs are resolved with this release: because they tail-call __syscall_cancel [34438] build: non reproducible build failure: sigaltstack-offsets.h: No such file or directory + [34439] build: parallel make install fails on multi-ABI targets: no + rule to make $(inst_includedir)/gnu/lib-names-$(abi).h in csu [34441] math: math: sinh() returns wrong results for some inputs with |x| > 36.736801 [34465] math: math: x86_64 tanh ifunc selection wrong