Re: xstrtol-error: Use quote() before print command line arguments.

Hi Collin,

Collin Funk wrote:
> I went ahead and pushed that patch. Will update coreutils in a bit.

Today's CI reports failures on macOS and FreeBSD.

On macOS:

/Users/runner/work/ci-testdir-check/ci-testdir-check/macos-compile clang -std=gnu23 -Wno-error -Wno-error -g -O2  -L/Users/runner/lib -L/opt/homebrew/opt/gettext/lib -L/opt/homebrew/opt/libiconv/lib -o test-xstrtoimax test-xstrtoimax.o libtests.a ../gllib/libgnu.a libtests.a ../gllib/libgnu.a libtests.a  -lintl -Wl,-framework -Wl,CoreFoundation -Wl,-framework -Wl,CoreServices -lbacktrace           
ld: warning: ignoring duplicate libraries: '../gllib/libgnu.a', 'libtests.a'
Undefined symbols for architecture arm64:
  "_libiconv", referenced from:
      _locale_encoding_to_unicode in libgnu.a[617](lc-charset-unicode.o)
      _unicode_to_locale_encoding in libgnu.a[617](lc-charset-unicode.o)
  "_libiconv_close", referenced from:
      _get_converters in libgnu.a[617](lc-charset-unicode.o)
      _get_converters in libgnu.a[617](lc-charset-unicode.o)
      _get_converters in libgnu.a[617](lc-charset-unicode.o)
      _get_converters in libgnu.a[617](lc-charset-unicode.o)
      _get_converters in libgnu.a[617](lc-charset-unicode.o)
      _get_converters in libgnu.a[617](lc-charset-unicode.o)
      _free_converters in libgnu.a[617](lc-charset-unicode.o)
      _free_converters in libgnu.a[617](lc-charset-unicode.o)
      ...
  "_libiconv_open", referenced from:
      _get_converters in libgnu.a[617](lc-charset-unicode.o)
      _get_converters in libgnu.a[617](lc-charset-unicode.o)
      _get_converters in libgnu.a[617](lc-charset-unicode.o)
      _get_converters in libgnu.a[617](lc-charset-unicode.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[4]: *** [test-xstrtoimax] Error 1

On FreeBSD:

depbase=`echo test-xstrtoimax.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; cc -DHAVE_CONFIG_H -DEXEEXT=\"\" -DEXEEXT=\"\" -I. -I../../gltests -I..  -DGNULIB_STRICT_CHECKING=1  -DIN_GNULIB_TESTS=1  -I. -I../../gltests  -I.. -I../../gltests/..  -I../gllib -I../../gltests/../gllib  -I/usr/local/include -Wall -DCONTINUE_AFTER_ASSERT -D_THREAD_SAFE -Wno-error -Wno-error -g -O2 -MT test-xstrtoimax.o -MD -MP -MF $depbase.Tpo -c -o test-xstrtoimax.o ../../gltests/test-xstrtoimax.c && mv -f $depbase.Tpo $depbase.Po
cc -Wno-error -Wno-error -g -O2  -L/usr/local/lib -o test-xstrtoimax test-xstrtoimax.o libtests.a ../gllib/libgnu.a libtests.a ../gllib/libgnu.a libtests.a  /usr/local/lib/libintl.so -Wl,-rpath -Wl,/usr/local/lib -lbacktrace -lm -lm -lm -lm -lm -lm -lm -lm -lm -lm -lm
ld: error: undefined symbol: libiconv
>>> referenced by lc-charset-unicode.c:177 (../../gllib/lc-charset-unicode.c:177)
>>>               lc-charset-unicode.o:(locale_encoding_to_unicode) in archive ../gllib/libgnu.a
>>> referenced by lc-charset-unicode.c:236 (../../gllib/lc-charset-unicode.c:236)
>>>               lc-charset-unicode.o:(unicode_to_locale_encoding) in archive ../gllib/libgnu.a

ld: error: undefined symbol: libiconv_open
>>> referenced by lc-charset-unicode.c:115 (../../gllib/lc-charset-unicode.c:115)
>>>               lc-charset-unicode.o:(get_converters) in archive ../gllib/libgnu.a
>>> referenced by lc-charset-unicode.c:116 (../../gllib/lc-charset-unicode.c:116)
>>>               lc-charset-unicode.o:(get_converters) in archive ../gllib/libgnu.a
>>> referenced by lc-charset-unicode.c:96 (../../gllib/lc-charset-unicode.c:96)
>>>               lc-charset-unicode.o:(get_converters) in archive ../gllib/libgnu.a
>>> referenced 1 more times

ld: error: undefined symbol: libiconv_close
>>> referenced by lc-charset-unicode.c:127 (../../gllib/lc-charset-unicode.c:127)
>>>               lc-charset-unicode.o:(get_converters) in archive ../gllib/libgnu.a
>>> referenced by lc-charset-unicode.c:128 (../../gllib/lc-charset-unicode.c:128)
>>>               lc-charset-unicode.o:(get_converters) in archive ../gllib/libgnu.a
>>> referenced by lc-charset-unicode.c:122 (../../gllib/lc-charset-unicode.c:122)
>>>               lc-charset-unicode.o:(get_converters) in archive ../gllib/libgnu.a
>>> referenced 5 more times
cc: error: linker command failed with exit code 1 (use -v to see invocation)
*** Error code 1

Stop.
make[4]: stopped in /home/runner/work/ci-testdir-check/ci-testdir-check/testdir-all/build/gltests