Re: [PATCH 2/8] fcntl-h: glibc now has openat2

Paul Eggert wrote:
> diff --git a/doc/glibc-functions/openat2.texi b/doc/glibc-functions/openat2.texi
> new file mode 100644
> index 0000000000..a29461fb59
> --- /dev/null
> +++ b/doc/glibc-functions/openat2.texi
> @@ -0,0 +1,21 @@
> +@node openat2
> +@subsection @code{openat2}
> +@findex openat2
> +
> +Documentation:@* @uref{https://www.kernel.org/doc/man-pages/online/pages/man2/openat2.2.html,,man openat2}
> +
> +Gnulib module: ---

This should mention the module 'openat2' here, I guess?
And add a
  @mindex openat2
line, as usual.

> diff --git a/m4/fcntl_h.m4 b/m4/fcntl_h.m4
> index 946a0bd632..3a5ddb2219 100644
> --- a/m4/fcntl_h.m4
> +++ b/m4/fcntl_h.m4
> @@ -1,5 +1,5 @@
>  # fcntl_h.m4
> -# serial 21
> +# serial 22
>  dnl Copyright (C) 2006-2007, 2009-2026 Free Software Foundation, Inc.
>  dnl This file is free software; the Free Software Foundation
>  dnl gives unlimited permission to copy and/or distribute it,
> @@ -67,7 +67,7 @@ AC_DEFUN([gl_FCNTL_H_DEFAULTS]
>    dnl Assume proper GNU behavior unless another module says otherwise.
>    HAVE_FCNTL=1;          AC_SUBST([HAVE_FCNTL])
>    HAVE_OPENAT=1;         AC_SUBST([HAVE_OPENAT])
> -  HAVE_OPENAT2=0;        AC_SUBST([HAVE_OPENAT2])
> +  HAVE_OPENAT2=1;        AC_SUBST([HAVE_OPENAT2]) dnl GNU/Linux only
>    REPLACE_CREAT=0;       AC_SUBST([REPLACE_CREAT])
>    REPLACE_FCNTL=0;       AC_SUBST([REPLACE_FCNTL])
>    REPLACE_OPEN=0;        AC_SUBST([REPLACE_OPEN])
> 

This makes no sense. Previously, HAVE_OPENAT2 was set to 0 as a fallback
and to 1 (in m4/openat2.m4) on platforms that have the function. With
the change above, HAVE_OPENAT2 gets set to 1 on *all* platforms.

Bruno