Re: In coreutil 9.11, translations are not displayed in locales other than English
Collin Funk <[email protected]>
| Newsgroups | gmane.comp.lib.gnulib.bugs,gmane.comp.gnu.coreutils.general |
|---|---|
| Message-ID | <[email protected]> |
Paul Eggert <[email protected]> writes: > Problem reported by ribbon in: > https://lists.gnu.org/r/coreutils/2026-08/msg00093.html > * configure.ac (GNULIB_TEXT_DOMAIN): Define. > * po/POTFILES.in: Add lib/parse-datetime.y. > --- > NEWS | 3 +++ > configure.ac | 4 ++++ > po/POTFILES.in | 1 + > 3 files changed, 8 insertions(+) This causes a syntax-check failure: po_check --- ./po/POTFILES.in +++ ./po/POTFILES.in @@ -10,7 +10,6 @@ lib/mkdir-p.c lib/obstack.c lib/openat-die.c -lib/parse-datetime.y lib/quotearg.c lib/randread.c lib/regcomp.c maint.mk: you have changed the set of files with translatable diagnostics; apply the above patch make: *** [maint.mk:1367: sc_po_check] Error 1 The check was only accounting for C sources and headers, which was probably why this was missed previously. I pushed the attached patched to Gnulib and updated it in Coreutils to fix it. I also noticed that maint.mk assumes 'gnulib-tool --import' is not given an '--source-base=...' argument. That is a seperate issue than this, though. And one that can probably be left until someone requires it. Collin
0001-maintainer-makefile-Fix-false-sc_po_check-failure-wi.patch
(text/x-patch, 1.5 KB)
From ae3de5b4e9519d9cfbe2d9939eb1377a75d65c88 Mon Sep 17 00:00:00 2001 Message-ID: <ae3de5b4e9519d9cfbe2d9939eb1377a75d65c88.1787720544.git.collin.funk1@gmail.com> From: Collin Funk <[email protected]> Date: Tue, 25 Aug 2026 21:41:47 -0700 Subject: [PATCH] maintainer-makefile: Fix false sc_po_check failure with bison sources. * top/maint.mk (generated_files): Also match files ending with the '.y' extension. --- ChangeLog | 6 ++++++ top/maint.mk | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 2eb0f5f952..ef85f14d1a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2026-08-25 Collin Funk <[email protected]> + + maintainer-makefile: Fix false sc_po_check failure with bison sources. + * top/maint.mk (generated_files): Also match files ending with the '.y' + extension. + 2026-08-25 Paul Eggert <[email protected]> gettext-h: always define textdomain diff --git a/top/maint.mk b/top/maint.mk index 2ba6b00f4e..1cfdfe7c0e 100644 --- a/top/maint.mk +++ b/top/maint.mk @@ -1361,7 +1361,7 @@ perl_translatable_files_list_ = \ # Verify that all source files using _() (more specifically, files that # match $(_gl_translatable_string_re)) are listed in po/POTFILES.in. po_file ?= $(srcdir)/po/POTFILES.in -generated_files ?= $(srcdir)/lib/*.[ch] +generated_files ?= $(srcdir)/lib/*.[chy] _gl_translatable_string_re ?= \b(N?_|gettext *)\([^)"]*("|$$) sc_po_check: @if test -f $(po_file); then \ -- 2.55.0