[bug #59204] NSOperationQueue leak

Larry Campbell <[email protected]>
Newsgroups gmane.comp.lib.gnustep.bugs
Message-ID <[email protected]>
Follow-up Comment #3, bug #59204 (project gnustep):

Looks like this bug was added by this commit:

commit 7380e850e4745282806e62320df5c016bfd4f31e
Author: Richard Frith-Macdonald <[email protected]>
Date:   Tue Dec 4 11:09:18 2018 +0000

    minor whitespace tidyups


The relevant part of that commit is:

@@ -973,11 +963,8 @@ - (void) _thread
            {
              NSAutoreleasePool *opPool = [NSAutoreleasePool new];
 
-             if (NO == [op isCancelled])
-               {
-                 [NSThread setThreadPriority: [op threadPriority]];
-                 [op main];
-               }
+              [NSThread setThreadPriority: [op threadPriority]];
+              [op start];

Changing "[op start]" back to "[op main]" fixes the leak.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?59204>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.