[bug #60952] NSTimeZone fail to deal with tzfile v2+

Richard Frith-Macdonald <[email protected]> Sun, 25 Jul 2021 02:48:05 -0400 (EDT)
Newsgroups gmane.comp.lib.gnustep.bugs
Message-ID <[email protected]>
Follow-up Comment #8, bug #60952 (project gnustep):

> but I note this bug:

Either the value of version is 1 (the value it's initialised to), or the
version is not 1 (and is set to header->tzh_version[0])

>   if (1 == version)
> That will always be false.

No, that will be false only if it's a version 2 or later (because for a
version 1 file the variable was initialised to 1).

However, you are right to point out that tzh_version[0] is an ascii character
for version2+, so the assignment should really convert that to an integer. 
I'll change it to subtract '0' when setting the variable.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?60952>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/