Re: bug and fix for gnustep-base

Hi Carl,


Thank you for this bug report. This is already fixed in the main branch, we j=
ust need to have a new release to publish that change. Could you please try t=
o clone this version and verify that the issue is resolved?

Cheers,
Fred


On the road

> Am 22.10.2023 um 07:17 schrieb Carl Hansen <[email protected]>:
>=20
> =EF=BB=BFI am disinclined to register at Microsoft github, so I post the b=
ug here.
>=20
>=20
> the situation:
>=20
> compiling gnustep-base 1.29.0  with the latest libxml2 which is 2.11.5
>=20
>=20
> the problem:
>=20
>=20
> GSXML.m: In function 'getEntityDefault':
> GSXML.m:2674:22: error: 'xmlEntity' {aka 'struct _xmlEntity'} has no membe=
r named 'checked'
> 2674 |               if (ret->checked =3D=3D 0)
>      |                      ^~
> GSXML.m:2676:22: error: 'xmlEntity' {aka 'struct _xmlEntity'} has no membe=
r named 'checked'
> 2676 |                   ret->checked =3D 1;
>      |                      ^~
>=20
> the reason:
>      Like it says, "no member named 'checked'"
>=20
>      Here is the relevant change in libxml2 :
>      https://gitlab.gnome.org/GNOME/libxml2/-/commit/ce76ebfd1312459951d55=
5ad9d87fb9a89eede55
>=20
>=20
>=20
> the patch:
>=20
>=20
> diff -x config.log -x config.status -ru tmp/gnustep-base-1.29.0/Source/Add=
itions/GSXML.m work/gnustep-base-1.29.0/Source/Additions/GSXML.m
> --- tmp/gnustep-base-1.29.0/Source/Additions/GSXML.m    2023-01-08 00:41:3=
2.000000000 -0800
> +++ work/gnustep-base-1.29.0/Source/Additions/GSXML.m    2023-10-21 13:51:=
29.989588310 -0700
> @@ -2671,10 +2671,12 @@
>                   return NULL;
>                 }
>               ret->owner =3D 1;
> -              if (ret->checked =3D=3D 0)
> +              /* non-existent field
> +            if (ret->checked =3D=3D 0)
>                 {
>                   ret->checked =3D 1;
>                 }
> +           ****    */
>             }
>         }
>     }
>=20
>=20
>=20
>=20