Re: GNUstep releases this month?
Richard Frith-Macdonald <[email protected]> Mon, 22 Mar 2021 17:19:06 +0000
| Newsgroups | gmane.comp.lib.gnustep.devel |
|---|---|
| Message-ID | <[email protected]> |
> On 22 Mar 2021, at 15:25, Frederik Seiffert <[email protected]> wrote: > > >> Am 19.03.2021 um 16:40 schrieb Ivan Vučica <[email protected]>: >> >> I am thinking of doing it this weekend, any objection? > > > The NSFileHandle/singleton tests in Base have been failing for the last couple commits. > > The test logs look like this – trying to release the singletons correctly throws an exception, but then it seems that the retain count is still zero for the singleton objects: > >> Passed test: (2021-03-17 16:59:18.407 +0000) singleton.m:18 ... stdin persists >> Passed test: (2021-03-17 16:59:18.408 +0000) singleton.m:19 ... stdout persists >> Passed test: (2021-03-17 16:59:18.408 +0000) singleton.m:20 ... strerr persists >> Throwing 0x244e538, in flight exception: (nil) >> Exception caught by C++: 0 >> Passed test: (2021-03-17 16:59:18.408 +0000) singleton.m:21 ... Cannot dealloc stdin >> Throwing 0x244e748, in flight exception: 0x244e538 >> Exception caught by C++: 0 >> Passed test: (2021-03-17 16:59:18.408 +0000) singleton.m:22 ... Cannot dealloc stdout >> Throwing 0x247a578, in flight exception: 0x244e748 >> Exception caught by C++: 0 >> Passed test: (2021-03-17 16:59:18.408 +0000) singleton.m:23 ... Cannot dealloc stderr >> Failed test: (2021-03-17 16:59:18.408 +0000) singleton.m:24 ... stdin persists >> Failed test: (2021-03-17 16:59:18.408 +0000) singleton.m:25 ... stdout persists >> Failed test: (2021-03-17 16:59:18.408 +0000) singleton.m:26 ... strerr persists > > > The failures started with one of these two commits from myself, but I cannot figure out how they could have caused the above: > https://github.com/gnustep/libs-base/commit/54ae296b694187b0c92dfd9bb55dfea58f357e84 > https://github.com/gnustep/libs-base/commit/5fb5fb46c404601f6fe8d6bbb7ecaae0af7f0ba7 > > Any ideas about what might be going on here? Could any change in Make or libobjc2 maybe have caused the above? I compared build logs between the last successful runs and the failed runs. They were identical except for the failed tests, but they also don’t show which version of the dependencies was checked out so there might have been a difference there. I was just looking at that. The tests are passing for me on debian-10 (gcc) and fedora-33 (with both gcc and clang with libobjc2 from some months ago) The text >> Throwing 0x247a578, in flight exception: 0x244e748 >> Exception caught by C++: 0 appears to be a libobjc bug (one that Riccardo mentioned to me). But I don't know if this spurious output is related to the test failure. I'm guessing that the issue is a recent libobjc2 one though.