Re: base: running make in Documentation subdir broken

Thank you! Seeing the patch was informative and a learning experience.

On Fri, Apr 23, 2021 at 6:58 AM Richard Frith-Macdonald
<[email protected]> wrote:
>
>
>
> > On 22 Apr 2021, at 22:32, Ivan Vučica <[email protected]> wrote:
> >
> > Hi,
> >
> > when running "Generating reference documentation...", the output is
> > now full of screenfuls upon screenfuls of:
> >
> > ../Headers/Foundation/NSNumberFormatter.h:501 Unexpected char (-) in declaration
> > ../Headers/Foundation/NSNumberFormatter.h:502 Unexpected char (-) in declaration
> > ../Headers/Foundation/NSNumberFormatter.h:504 Unexpected char (-) in declaration
> > ../Headers/Foundation/NSNumberFormatter.h:505 Unexpected char (-) in declaration
> > ../Headers/Foundation/NSNumberFormatter.h:507 Unexpected char (-) in declaration
> > ../Headers/Foundation/NSNumberFormatter.h:508 Unexpected char (-) in declaration
> > ../Headers/Foundation/NSNumberFormatter.h:510 Unexpected char (-) in declaration
> > ../Headers/Foundation/NSNumberFormatter.h:511 Unexpected char (-) in declaration
> > ../Headers/Foundation/NSNumberFormatter.h:515 Unexpected char (+) in declaration
> > ../Headers/Foundation/NSNumberFormatter.h:523 Argh ... read '}' when
> > looking for ';'
> > ../Headers/Foundation/NSObject.h:292 Unexpected char (@) in declaration
> > ../Headers/Foundation/NSObject.h:308 Unexpected char (-) in declaration
> > ../Headers/Foundation/NSObject.h:312 Unexpected char (-) in declaration
> > ../Headers/Foundation/NSObject.h:315 Unexpected char (+) in declaration
> > ../Headers/Foundation/NSObject.h:316 Unexpected char (+) in declaration
> > ../Headers/Foundation/NSObject.h:317 Unexpected char (+) in declaration
> > ../Headers/Foundation/NSObject.h:339 Unexpected char (+) in declaration
> > ../Headers/Foundation/NSObject.h:364 Unexpected char (+) in declaration
> >
> >
> > I'm unfamiliar with how our doc generators work. What could we have
> > done to break them? Could this be releated to DLLEXPORT changes for
> > Windows?
> >
> > Richard, is this a release stopper?
>
> I suppose, but fortunately easy to fix;  I added GS_EXPORT_CLASS to the set of 'words' the automatic generation should ignore when building base and base additions documentation.