Re: Patches for supporting Sinhala script

Hello Harsha,

Thanks for sending these patches. It's great to get information about a 
whole new Indic script! I looked them over briefly, and they seem fine, 
though I share your concern about how the change in IndicReordering.cpp 
will effect the other Indic scripts.

Unfortunately, I don't think I'll have enought time to get these changes 
into ICU 2.8, due at the end of this year; our 2.8 schedule was decided 
a couple of months ago, and is pretty full. I've been accumulating a 
small list of bugs for other Indic scripts, which I'm planning to 
address in ICU 3.0 early next year. I'll probably add Sinhala at the 
same time.

If I get a few spare moments, I'll try and test your patches with the 
other Indic scripts to see if anything breaks.

Regards,
Eric Mader
IBM GCoC - San José
5600 Cottle Rd.  M/S 50-2 / B11
San Jose, CA 95193

[email protected] wrote:

> 
> 
> 
> Dear Sir,
> 
> I have made the necessary amendments to IndicClassTables.cpp and
> LayoutEngine.cpp.
> 
> I have also made a small modification to saveMatra() method in
> IndicReordering.cpp. This hack was done because in Sinhala there are
> two-part dependent vowel signs  ( DIGA KOMBUVA (0x0DDA) & SINHALA VOWEL
> SIGN KOMBUVA HAA DIGA AELA-PILLA (0x0DDD) ) which are composed of a matra
> and a virama/halant sign, and when they are split and reordered the virama
> sign was getting dropped. I am not familiar with other indic scripts and
> what affect this will have on them so I just made this temp hack for my
> testing purposes.
> 
> I was not quite sure about the script_flags so I just used the tamil script
> flags since Tamil script is very close to Sinhala. I have tested the shaper
> using Layoutsample and microsoft 'Iskoola pota'  (beta) opentype font.
> 
> If these patches are ok, I would like to update the pango code as well.  My
> objective is to see Sinhala on Linux desktop.
> 
> thank you.
> Yours sincerely,
> Harsha Senanayake.
> 
> ps will these patches go into ICU4J?
> 
> (See attached file: IndicClassTables.patch)(See attached file:
> IndicReordering.patch)(See attached file: LayoutEngine.patch)(See attached
> file: icu_sinhala.jpg)
> _____________________________________________________________________________________________________
> 
> CONFIDENTIALITY AND DISCLAIMER
> 
> This communication is privileged and confidential, and is directed to and
> for the use of the addressee only. If this message reaches any person other
> than the intended recipient, we request such person to preserve its
> confidentiality,  not read, reproduce, copy, disseminate or in any manner
> distribute it. We further request such recipient to notify us immediately
> by email that such message has been received and delete the original
> message.
> 
> 
> Please note that we reserve the right to monitor all email communications
> through our network.
> 
> 
> 
> Home Page : www.keells.com
> 
> __________________________________________
> 
> 
> ------------------------------------------------------------------------
>