Re: tibetan rendering support in ICU

Eric Mader <[email protected]> Tue, 02 Nov 2004 09:43:23 -0800
Newsgroups gmane.comp.lib.icu.general
Message-ID <[email protected]>
Hello Karunakar,

Jens' analysis looks correct to me. The featureTags variable is a 
pointer to a pointer to a tag, i.e. a pointer to an array of tags, so 
you need the "&" operator.

After a quick glance at your code, I have a few other comments:

* The adjustGlyphPositions() and glyphProcessing() methods look like 
they're the same as the ones which you would inherit from 
OpenTypeLayoutEngine. You can probably just inherit.

* If you have the option, I suggest that you work w/ a newer version of 
ICU - there have been many improvements and bug fixes made to the 
LayoutEngine since ICU 2.2. (We're about to release ICU 3.2!)

Regards,
Eric Mader
IBM GCoC - San José
5600 Cottle Rd.  M/S 50-2/B11
San Jose, CA 95193

Jens Herden wrote:
> Hi!
> 
> 
>>Any clues to what I am doing wrong would be helpful.
> 
> 
> I did a quick look into your files and my first guess is about this:
> 
>    featureTags[idx] = tagArray[1];
> 
> Don't you need to write 
> 
>    featureTags[idx] = &tagArray[1];
> there?
> 
> I saw similar code in the indic layout engine, but I might be wrong.
> 
> Jens
> _______________________________________________
> icu mailing list
> [email protected]
> http://oss.software.ibm.com/developerworks/oss/mailman/listinfo/icu
> 
>