Re: Patch - cplusplus ifdefs for src/SSL/*.h

Vic Bancroft <[email protected]> Sat, 22 Oct 2005 14:32:16 -0400
Newsgroups gmane.comp.lib.libwww
Organization netizens
Message-ID <[email protected]>
Sam Varshavchik wrote:

> In 5.4.0, src/SSL/*.h wasn't wrapped for c++ compiles.
>
> Here's a patch for that, if it hasn't been taken care of it already.

Auh yes, good catch !  All the header files should have that for ease of 
use in a mixed c / c++ world.

However, there is some interesting quirk in this library where most of 
the header files are actually generated from the cooresponding html 
documentation file.   All the bits inside preformatted tags are passed 
through to the header definitions . . .

So, the diff to wrap all the SSL headers in extern "C" is

    Index: HTSSL.html
    ===================================================================
    RCS file: /sources/public/libwww/Library/src/SSL/HTSSL.html,v
    retrieving revision 1.4
    diff -r1.4 HTSSL.html
    20a21,24
     >
     > #ifdef __cplusplus
     > extern "C" {
     > #endif
    79a84
     >
    80a86,90
     >
     > #ifdef __cplusplus
     > } /* end extern C definitions */
     > #endif
     >
    Index: HTSSLReader.html
    ===================================================================
    RCS file: /sources/public/libwww/Library/src/SSL/HTSSLReader.html,v
    retrieving revision 1.1
    diff -r1.1 HTSSLReader.html
    34a35,39
     >
     > #ifdef __cplusplus
     > extern "C" {
     > #endif
     >
    54a60,63
     > #ifdef __cplusplus
     > }
     > #endif
     >
    Index: HTSSLWriter.html
    ===================================================================
    RCS file: /sources/public/libwww/Library/src/SSL/HTSSLWriter.html,v
    retrieving revision 1.1
    diff -r1.1 HTSSLWriter.html
    34a35,38
     > #ifdef __cplusplus
     > extern "C" {
     > #endif
     >
    42a47,51
     >
     > #ifdef __cplusplus
     > }
     > #endif
     >
    Index: HTSSLhttps.html
    ===================================================================
    RCS file: /sources/public/libwww/Library/src/SSL/HTSSLhttps.html,v
    retrieving revision 1.1
    diff -r1.1 HTSSLhttps.html
    18a19,23
     >
     > #ifdef __cplusplus
     > extern "C" {
     > #endif
     >
    49a55,58
     > #ifdef __cplusplus
     > }
     > #endif
     >

more,
l8r,
v

-- 
"The future is here. It's just not evenly distributed yet."
 -- William Gibson, quoted by Whitfield Diffie