Patch - plug a memory leak
Sam Varshavchik <[email protected]> Sun, 09 Jul 2006 17:14:17 -0400
| Newsgroups | gmane.comp.lib.libwww |
|---|---|
| Message-ID | <[email protected]> |
This is a MIME GnuPG-signed message. If you see this text, it means that your E-mail or Usenet software does not support MIME signed messages. The Internet standard for MIME PGP messages, RFC 2015, was published in 1996. To open this message correctly you will need to install E-mail or Usenet software that supports modern Internet standards. --=_mimegpg-commodore.email-scan.com-6442-1152479657-0001 Content-Type: text/plain; format=flowed; charset="US-ASCII" Content-Disposition: inline Content-Transfer-Encoding: 7bit valgrind comes back with a memory leak in the new version of HTBound.c. When I rewrote HTBound.c last year, I copied some snippets from the old version into the new version on HTBound.c, I guess without fully understanding other parts of libwww. Can't really say for sure, but the old HTBound.c might've also been leaking in the same spot. The analogous HTStreamStack call in the old HTBound.c had the same parameters. Anyway, this patch makes valgrind happy. Perhaps someone who's more familiar with HTMerge can share a comment, here. Index: Library/src/HTBound.c =================================================================== RCS file: /cvsroot/lpmtool/libwww/Library/src/HTBound.c,v retrieving revision 1.2 diff -U3 -r1.2 HTBound.c --- Library/src/HTBound.c 5 Jan 2006 01:27:20 -0000 1.2 +++ Library/src/HTBound.c 9 Jul 2006 20:59:16 -0000 @@ -410,7 +410,7 @@ if (!isterminal) me->target = HTStreamStack(WWW_MIME,me->format, - HTMerge(me->orig_target, 2), + HTMerge(me->orig_target, 1), me->request, YES); } --=_mimegpg-commodore.email-scan.com-6442-1152479657-0001 Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (GNU/Linux) iD8DBQBEsXGpx9p3GYHlUOIRAs0aAJkBzz5FbIGu6uQP3W8RxhVRiur7KACeIHe0 +8ZOKllGvIHsqN1tXCzCfWY= =aMEJ -----END PGP SIGNATURE----- --=_mimegpg-commodore.email-scan.com-6442-1152479657-0001--