Re: New version of libccid: 1.4.15

Hello,

2014-02-25 18:21 GMT+01:00 Greg Troxel <[email protected]>:
>
> Ludovic Rousseau <[email protected]> writes:
>
>> I just released a version 1.4.15 of libccid the free software CCID
>> class smart card reader driver.
>> http://ludovicrousseau.blogspot.fr/2014/02/new-version-of-libccid-1415.html
>
> I updated pkgsrc/security/ccid to 1.4.15.  The code builds fine on
> NetBSD/i386 6-stable with gcc.
>
>
>
> In pkgsrc, the following patches are applied against ccid, and probably
> they should be applied upstream.
>
> $NetBSD: patch-ab,v 1.2 2012/12/15 00:29:31 pettai Exp $
>
> --- src/commands.c.orig 2012-12-11 19:36:05.000000000 +0000
> +++ src/commands.c
> @@ -161,7 +161,7 @@ RESPONSECODE CmdPowerOn(unsigned int rea
>
>                         /* Status Information? */
>                         if (0x40 == tmp[0])
> -                               ccid_error(tmp[2], __FILE__, __LINE__, __FUNCTION__);
> +                               ccid_error(tmp[2], __FILE__, __LINE__, (const char *) __FUNCTION__);
>                         return IFD_COMMUNICATION_ERROR;

Why do you need to cast __FUNCTION__?

What version and name of the compiler are you using?
What is the type of __FUNCTION__ on your compiler?

> --- src/ccid_usb.c.orig 2012-12-11 19:45:39.000000000 +0000
> +++ src/ccid_usb.c
> @@ -1106,7 +1106,7 @@ int InterruptRead(int reader_index, int
>         switch (ret)
>         {
>                 case LIBUSB_TRANSFER_COMPLETED:
> -                       DEBUG_XXD("NotifySlotChange: ", buffer, actual_length);
> +                       DEBUG_XXD("NotifySlotChange: ", (const unsigned char *) buffer, actual_length);
>                         break;
>
>                 case LIBUSB_TRANSFER_TIMED_OUT:

Using my source code [1], this code is at line 1246, not 1106. Strange.
Again I don't see why you need to cast buffer.
What is the warning for this code?

Regards,

[1] http://anonscm.debian.org/viewvc/pcsclite/trunk/Drivers/ccid/src/ccid_usb.c?view=markup

-- 
 Dr. Ludovic Rousseau