Re: perror() changes the orientation of stderr to byte-oriented mode if stderr is not oriented yet.

Hi Takashi,

On Jun 28 20:14, Takashi Yano wrote:
> Hi Corinna,
> 
> On Wed, 27 Jun 2018 14:55:03 +0200
> Corinna Vinschen wrote:
> > again, please send patches related to newlib to the newlib mailing list.
> > Newlib patches affect more targets than just Cygwin.  I redirected this
> > mail to the newlib list and attached your original attachments.  Thank
> > you.
> 
> Next time I will. Sorry for my inadequate understanding about newlib.

No worries.  When coming from the Cygwin side it's not immediately
obvious.

> > I'm not sure exactly.  It may be nice to keep the writes buffered
> > if the original stderr stream is buffered as well.
> > 
> > What about duplicating the non-_FVWRITE_IN_STREAMIO part of _fputs_r,
> > just without calling ORIENT?
> 
> Thank you for your suggestion.
> 
> I tried this but it failed because __sputc_r() called from _fputs_r also
> sets orientation. So I have borrowed the codes from __swbuf_r() in wbuf.c
> so that the strings are pushed directly into the buffer.
> 
> Could you please have a look?

I did.  Thanks for implementing this, but... uhm... I'm not really
thrilled.  So much extra code for such a simple thing as perror...?

On second thought I wonder if we shouldn't just go the FreeBSD route.

What's your stance?


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAls1KZwACgkQ9TYGna5E
T6CFGhAAjQ//hdkWkXXIpXVMa/JCDkyFzkNI/+XgfJnE9MCIkzjqgnCoHER7NXXr
8/CUeFM7w/M6svluUw2uMLSOHS7wIil6M4xggmsHIU5RPZnxo0ukgO63t4PH4Tsy
CNawQMYyDdiZb0HFpgpAy2qY9QRHNox7jfMISE6W0+qAslgAlkkXfkN0QWk9skD9
Hj89NMPeS/urnGci7An3d/hkD3jy3AMIiPgPuVjQSkmvz0JQLGwt+1PRBk0aC8Tx
2eUIOQYyO9bzFCXAyK3o26lS6u6ts8wUPrcsZv1wgXYJ08k3Izif27k+B0wSi9So
io/wCLtvuf60y3TILXBZG+G/pVi5ZTa2HGnv+QKvRVPGf0+bAapVGXEnjiWZnUw7
qhPwSoeXBeMjJDEZG798OD8fNcjHUzZyaQdevDFOXbhBfEYdOZdImysrEX0M1OJo
GnQLyOgxJdPvh3pPZTEkeoJgCxd3/WUrnZifv0U/sruEds+puBEj2EvRDMwamhoQ
wO0XqyIMYKERm+M9CnTSaytMY3Qwye5wwASzcQR/P0ys1QB8BKveuXuFviiMV+b9
Frq8F8yRsfZTvg3fw8fpafMM0790NvgE+j0RRDoe7Bd5cgWGmZJuQXonXEcp63Su
Ocl3V8Yp+h9SiLM/HGVknxo9Jqdg0Q7sKdJqzFrPQ9hwFn1cyMw=
=HGHc
-----END PGP SIGNATURE-----