Re: [PATCH] Fix to stop a fall-through in a switch statement

Corinna Vinschen <[email protected]> Fri, 13 Jul 2018 13:35:17 +0200

Newsgroups	gmane.comp.lib.newlib
Message-ID	<[email protected]>

On Jul 13 12:15, Jordi Sanfeliu wrote:
> Hello,
> 
> The following fixes a fall-through that prevented from reading the next
> entry in the UTMP file and terminated the program with an abort().
> 
> diff --git a/newlib/libc/unix/getut.c b/newlib/libc/unix/getut.c
> index c3a9b62..89ed739 100644
> --- a/newlib/libc/unix/getut.c
> +++ b/newlib/libc/unix/getut.c
> @@ -65,6 +65,7 @@ getutid (struct utmp *id)
>         case DEAD_PROCESS:
>           if (id->ut_id == utmp_data.ut_id)
>             return &utmp_data;
> +         break;
>         default:
>           abort ();
>         }

Your patch has whitespace problems (TABs -> space).  Just a hint
for next time, I applied and pushed it with changes for now.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

signature.asc (application/pgp-signature, 833 B)