Re: newlib Digest of: get.16090

> From: Corinna Vinschen <[email protected]>
> To: [email protected], Bin Cheng <[email protected]>
> Cc: Kumar Gala <[email protected]>
> Bcc:
> Date: Fri, 13 Jul 2018 13:37:43 +0200
> Subject: Re: [PATCH] Print sign of NaN values to nano-vfprintf.
> On Jul 12 13:13, Kumar Gala wrote:
> > Signed-off-by: Kumar Gala <[email protected]>
> > ---
> >  newlib/libc/stdio/nano-vfprintf_float.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/newlib/libc/stdio/nano-vfprintf_float.c b/newlib/libc/stdio/nano-vfprintf_float.c
> > index 98893e97b..071a09edc 100644
> > --- a/newlib/libc/stdio/nano-vfprintf_float.c
> > +++ b/newlib/libc/stdio/nano-vfprintf_float.c
> > @@ -213,6 +213,8 @@ _printf_float (struct _reent *data,
> >      }
> >    if (isnan (_fpvalue))
> >      {
> > +      if (_fpvalue < 0)
> > +     pdata->l_buf[0] = '-';
> >        if (code <= 'G')               /* 'A', 'E', 'F', or 'G'.  */
> >       cp = "NAN";
> >        else
> > --
> > 2.14.4
>
> Any comment from the nano-printf guys?

LGTM.

>
> Thanks,
> Corinna
>
> --
> Corinna Vinschen
> Cygwin Maintainer
> Red Hat

Best regards,

Thomas