Re: [PATCH] Improve sincosf comments

On Aug 10 11:34, Wilco Dijkstra wrote:
> Improve comments in sincosf implementation to make the code easier
> to understand. Build succeeds - no changes in generated code.
> 
> ChangeLog:
> 2018-08-10 Wilco Dijkstra  <[email protected]>
> 
>         * newlib/libm/common/cosf.c (cosf): Improve comment.
>         * newlib/libm/common/sincosf.h (pi63): Rename to pi63.
>         (sincos_t): Comment struct members.
>         (reduce_fast): Improve comments.
>         (reduce_large): Likewise.
>         * newlib/libm/common/sincosf.c (sincosf): Improve comment.
>         * newlib/libm/common/sinf.c (sinf): Likewise.
> --

Patch is ok, but we can really drop the CVS-style ChangeLogs now.  A
nice explanation of the changes would be more helpful, including a word
on the name change pi64 -> pi63.

Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAltxM74ACgkQ9TYGna5E
T6D9NRAAln5SCspQZxFPOhM1nxIm7ZN3fV8fF14jC24/guE/742Pe6oa25elPyHH
c3cE0vxBIvQEY0AOEZXke7jYEXEGY1j9vvx/5oHelHXwShd0iRBCHT9ftFRn3PV/
4Rn0bnkw/NGzsAyVNEHOLV6/foA/nDaI57eNgsaufHmlkG78stUJ5LQ4fqL6dADs
SoX4P3tg7ywaEK9t4QPLM9EuAJyAC3wke2Ue+jfxrlyf8loNfr8zYGqZhs+IYhlo
ovG+g3X+FLwX4/pbFcFep6yQo0nyhJd17PM7TaoS2WMEeQeH6STrjSCiOWuAGVMw
Iooou5+LFbwnT+bfKQCdntnIAAR2i0GPUFrrOD9iaofo4HFNQw6MyxoZGLi9e40/
xBeABlxzmXBaapqPxrMemcIpaOV6Df9Yb/g7xEuk0ay1N0FkaztJdeerZUR/Oaoo
/iqcF4oJbTZRYdFym27VT31xRBnc8aVIRJ1T7886X3IkUcN53387XnZdWdAjKL5t
ZcX1xZCd7r1VBQIH2NfucJlCXAz9Tov5LwVk3uSsHWKNV7Bx95FlEK0pRWz8ko1c
j6w8GU9AXrVt9lotngChfgGDQ0smrhTWS511TfwUtUxxZu6PA87U+pUxA+F6OsYF
9kBt5M1JS9KRAC7K6uivGk++xRXlu7mnNdqkTsNeIEoQl3Vdb38=
=iVw3
-----END PGP SIGNATURE-----