Re: [PATCH] libstdc++-v3: Have aligned_alloc() on Newlib
Szabolcs Nagy <[email protected]>
| Newsgroups | gmane.comp.gcc.libstdc++.devel,gmane.comp.gcc.patches,gmane.comp.lib.newlib |
|---|---|
| Message-ID | <[email protected]> |
On 13/08/18 19:57, Jonathan Wakely wrote: > On 13/08/18 13:04 +0100, Jonathan Wakely wrote: >> On 13/08/18 12:55 +0100, Szabolcs Nagy wrote: >>> On 09/08/18 10:08, Jonathan Wakely wrote: >>>> Yes please, on trunk and 7 and 8. It's better to use the standard >>>> aligned_alloc if available. >>>> >>> >>> but the newlib aligned_alloc is broken on baremetal targets, >>> it is implemented using posix_memalign which is not provided >>> by the newlib malloc implementation (except on cygwin) >> >> Ouch, OK, let's revert it. Using memalign is fine. >> >> The original problem that I think Sebastian was trying to solve should >> be fixed by r263409 anyway (and was backported to all branches). > > I've committed this to trunk and will do so on the branches too. > thanks, this fixed the issue for me on trunk.