Re: [PATCH] Improve sincosf comments
Corinna Vinschen <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <[email protected]> |
On Aug 16 10:39, Wilco Dijkstra wrote: > Corinna Vinschen wrote: > > > Patch is ok, but we can really drop the CVS-style ChangeLogs now. A > > nice explanation of the changes would be more helpful, including a word > > on the name change pi64 -> pi63. > > That is good news! How about the following: > > > Improve comments in sincosf implementation to make the code easier > to understand. Rename the constant pi64 to pi63 since it's actually > PI * 2^-63. Add comments for fields of sincos_t structure. Add comments > describing implementation details to reduce_fast. Pushed, thanks! Corinna -- Corinna Vinschen Cygwin Maintainer Red Hat
signature.asc
(application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAlt1X2sACgkQ9TYGna5E T6D6gw/+IXrKZ4IDM6zEU2tY/fZerZ1hAh2miE1nT0jbuhiZxoW6GetNVPPNPEAq OsW/NEDgvmiMkmtOC+EQYyb2K+4ZgJBbXEKCm/LM7IGddt2scx4QT2sSmKx1leYx CV2yU6rQnZCsAU/kUQnMmxxDKETUUivSFRTHmWcS5jVslF7+MfyXvLLVm2K4wYLP Q1J2mQIKHOkkYyG2D/obKwKce3gqmmfAPdxYuUNZlcuSFzTpSWrlQnKNi50eXgQT Dyt5UgPWOaNgKV9kMaWLTY3qb/il40xG1+e1Uh8cowUaLTzqykYd0+6pMJOOE1qS wunRsE7JaSML9WcZi5vtyYHr/BKq3aqYRv9sTURPrQwMRuZfIdBqp9OIPghrHSQ9 5/Z8e6B+PveykKTMFeZ+YLFbXWSTOd4FEAFmAcO06l3sNh612cPwdhIMNnNctwsj TXqmUaa+czSRZqM7jnU3fof5p85JrZZJ8xLNyU7gJ9qUE/u/dMwDZi0hERI760kz VvPvMv8QBM/gO05pEd++EZRdARkGqPwvB1F2RzwOkDiivdZlQGgrsN4E5/S4Sedq OhvMJv/fC4I+cWNGROfepwpSUVvmrj+NkrPJckPqvF4d5UzZts8Sv2axhCwd+dqQ uGR2lCEgPejXh3zBX+aOyVlD2hxrjmDHPIdBJppG7IdrKTNlONA= =jEjO -----END PGP SIGNATURE-----