Re: [PATCH] Remove log2 define

On Aug 24 14:37, Wilco Dijkstra wrote:
> Since newlib now has a fast implementation of log2,

Only if !__OBSOLETE_MATH

> remove a define which
> avoids calling log2.  The define makes math code slower and less accurate,
> so removing it is best.
> 
> Build OK on AArch64, OK for commit?
> 
> --
> diff --git a/newlib/libc/include/math.h b/newlib/libc/include/math.h
> index 893a5d0645148af0dd0a48f7e73504e07363a840..2d17dd13e52ae1893beba8c9a2565d7682dbbf89 100644
> --- a/newlib/libc/include/math.h
> +++ b/newlib/libc/include/math.h
> @@ -329,9 +329,6 @@ extern double lgamma (double);
>  extern double erf (double);
>  extern double erfc (double);
>  extern double log2 (double);
> -#if !defined(__cplusplus)
> -#define log2(x) (log (x) / _M_LN2)
> -#endif
>  
>  #ifndef __math_68881
>  extern double hypot (double, double);

Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAluAGicACgkQ9TYGna5E
T6CN8w//XNWPkZWFP3XUdPdcBVMAu64oq2vmIeuCXRF8KuB1sKWVtPuvyPjJqX4U
xT5Qh2eNj/J35fDut6dvqgKCqfbGAk8SX5cUAN3kpUF1XXJ6TgGB9CBVr+rTBn8a
SpvWVAo6l9dVkW7mNXT0fchc97TkWAvweF8ERHWPyguzDmAn7TMsewWwAQMTxFUg
q0gMYsNp2Ig7X3uR2RDh+rP6S0tAXfZVgTTk59ZYBnoHwotnUGJildZqoLkgUisi
O4FGz9COz+PyXRdg/2meNCexONgSSM53FhBZVkLzVQh+VGkrtG7FJ7v77jlqkNOM
/iT1fl5yUrP+OpTNsHbAOfpKQ5iXuvkRNWpBfBHuBnJrOMLHYCVBQBF079BT+JFy
a36R7m6rnTK4DJDU6PzZi1c1PedfBmLszzBjIYRanI+gwyTbci8iNN537hfgXDY/
CDOYGgww8cR8G5ZQGVEhTPbaZY5Y1JfPPbfPvcTdNQSrNYIU13fmJwjAPHNlVWbp
yv/TT7xNmQyNfr9n5Phaf8T8oOlNB0M+rhMbr1xC7GIANBQfxoVJw8drYvA8/lD4
eUFwvpdXNKlgadgmic4GnbgOz9VZPSY3g8bTfLfq9qcuHujkquLvG8iwfy5Sfvhk
T11/m98e59H7qLxPve4vRX9JsQukCJTOMgL7A8YDZc/yYvvm1gw=
=pD2A
-----END PGP SIGNATURE-----