Re: [PATCH] Use !__HAVE_LOCALE_INFO__ define to use _ctype_ directly [v2]

Corinna Vinschen <[email protected]> Thu, 6 Sep 2018 14:22:37 +0200

Newsgroups	gmane.comp.lib.newlib
Message-ID	<[email protected]>

On Sep  5 21:39, Keith Packard wrote:
> When __HAVE_LOCALE_INFO__ is not selected, directly access the
> existing _ctype_ variable from __locale_ctype_ptr() and
> __locale_ctype_ptr_l(), eliminating the need for any locale or reent
> structure
> 
> Signed-off-by: Keith Packard <[email protected]>
> 
> v2:
> 	locale: fix conflict with __locale_ctype_ptr macro
> 
> 	If we are building without __HAVE_LOCALE_INFO__, there is a
> 	macro providing __locale_ctype_ptr which in turn fouls up this
> 	declaration.
> 
> 	Signed-off-by: Michael Lyle <[email protected]>
> ---
> 
> This is one of a set of patches designed to reduce the number of
> functions which need reent and a locale structures in smaller
> configurations. In this case, I want to make the ctype macros directly
> access the existing _ctype_ global array instead of jumping through a
> function to get a locale structure out of a reent structure.
> 
> However, I'm not sure __HAVE_LOCALE_INFO__ is the right flag to use
> for this. If another existing configure flag is appropriate, I'd like
> to know. Or perhaps I just need a new flag?
> 
>  newlib/libc/include/ctype.h    | 9 +++++++++
>  newlib/libc/locale/locale.c    | 2 ++
>  newlib/libc/locale/setlocale.h | 8 ++++++++
>  3 files changed, 19 insertions(+)

Pushed.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

signature.asc (application/pgp-signature, 833 B)