Re: [PATCH v2] Make some standard open() flags visible

On Oct 10 15:32, Sebastian Huber wrote:
> Make the POSIX O_CLOEXEC, O_NOFOLLOW, O_DIRECTORY, O_EXEC, and O_SEARCH
> open() flags available also to non-Cygwin systems.
> 
> Make the BSD/glibc O_DIRECT open() flag  available also to non-Cygwin
> systems.

LGTM, but one last question.

> +/* POSIX-1.2008 specific flags */
> +#if __POSIX_VISIBLE >= 200809
> +#define	O_CLOEXEC	_FNOINHERIT
> +#define	O_NOFOLLOW	_FNOFOLLOW
> +#define	O_DIRECTORY	_FDIRECTORY
> +#define	O_EXEC		_FEXECSRCH
> +#define	O_SEARCH	_FEXECSRCH
> +#endif
> +
> +#if __BSD_VISIBLE
> +#define	O_DIRECT	_FDIRECT
> +#endif
> +
> +#if defined (__CYGWIN__)
>  #define O_BINARY	_FBINARY
>  #define O_TEXT		_FTEXT
>  #define O_DSYNC         _FSYNC
>  #define O_RSYNC         _FSYNC
> -#define O_EXEC          _FEXECSRCH
> -#define O_SEARCH        _FEXECSRCH
> -
> -/* POSIX-1.2008 specific flags */
> -#if __POSIX_VISIBLE >= 200809

Doesn't that require to #define _POSIX_C_SOURCE 200809L in your
libc/posix/opendir.c patch?

> -#define O_CLOEXEC	_FNOINHERIT
> -#define O_NOFOLLOW      _FNOFOLLOW
> -#define O_DIRECTORY     _FDIRECTORY
> -#endif
>  
>  /* Linux-specific flags */
>  #if __GNU_VISIBLE
> -#define O_DIRECT        _FDIRECT
>  #define O_TMPFILE	_FTMPFILE
>  #define O_NOATIME	_FNOATIME
>  #endif
> -- 
> 2.16.4


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAlu+FA8ACgkQ9TYGna5E
T6DjeQ/9G9qDT5VxPeW2ep1qBW0ssLjDMEQ4ONPcJTt18UWV74vmEnA4XzRuIbYI
ipJh/D/wiJivgHU5epo2i8xDGzp0YLA11bvwuf4l5Rdiqc2JXZW83fIQfNfx0i2+
kILRZNX7IauQSlUP3qe3WRmQKEfDfZCJ+S6mmyHR3jPxdM7m0YpLmNxaACHJTbxx
NUG8SDtpcBlIjUqM/Nedn1cpIDXyq61sWb95UFtW8gVbIkV+fsYa5IebQqueIRKi
kgmUtsPNDs4dotGEP6DXciPKa/RuykBABx+JTZDKzRH3vooDyBGb+JyDqXm+SGPE
AlT7jRBwzKo1H30u+kLIlaPc1y8nQd+n84lUFw2HXZF46EM756WVrANduhJNRSO+
fH0nbJgBEmMGk2fjSapVmurD5hHOi0M+AyGiaAHMtjZpI4byTO6VcLiT2+vudJQ4
/wlEJh7bcmmIZ3zKN5bIyQJyxWhYPrKrQhh/qPlL4ZqCZQrB4cPz47jv2P71YWwa
2/sprf99m41WR9q1CkP/oMCL6+1ycTX9QFQb9BZlr04cbht8mmYDec8kD1F51oGN
HkPuAdBBhfcyo8fc/E8mFPvkwaOsTIFj0nNJS2t/6p6LuCSV2uGI1LO/iPnfe4iv
AKYolRlcXo2s/ZIXG76v963y+6+AX4vt7Aj6PRSruX2T2XwJ780=
=NR58
-----END PGP SIGNATURE-----