Re: [PATCH 2/3] Move register_t to system-specific header

Corinna Vinschen <[email protected]> Wed, 13 Feb 2019 18:06:18 +0100

Newsgroups	gmane.comp.lib.newlib
Message-ID	<[email protected]>

On Feb 13 14:19, Sebastian Huber wrote:
> Signed-off-by: Sebastian Huber <[email protected]>
> ---
>  newlib/libc/include/machine/types.h           | 2 ++
>  newlib/libc/include/sys/types.h               | 2 +-
>  newlib/libc/sys/rtems/include/machine/types.h | 2 ++
>  winsup/cygwin/include/machine/types.h         | 2 ++
>  4 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/newlib/libc/include/machine/types.h b/newlib/libc/include/machine/types.h
> index 19d0e8560..fab9cf72c 100644
> --- a/newlib/libc/include/machine/types.h
> +++ b/newlib/libc/include/machine/types.h
> @@ -11,3 +11,5 @@ typedef	__uint64_t	u_quad_t;
>  typedef	__int64_t	quad_t;
>  typedef	quad_t *	qaddr_t;
>  #endif
> +
> +typedef int register_t;
> diff --git a/newlib/libc/include/sys/types.h b/newlib/libc/include/sys/types.h
> index 2685df654..e05263d4e 100644
> --- a/newlib/libc/include/sys/types.h
> +++ b/newlib/libc/include/sys/types.h
> @@ -36,7 +36,7 @@ typedef __uint32_t	u_int32_t;
>  #if ___int64_t_defined
>  typedef __uint64_t	u_int64_t;
>  #endif
> -typedef int register_t;
> +
>  #define __BIT_TYPES_DEFINED__ 1

Why move this out here?  Sure, it's wrong for 64 bit targets ATM,
but moving it to rtems and Cygwin only means that the type suddenly
disappears for other targets.  Better just fix it here for all targets,
including defining uregister_t if __BSD_VISIBLE.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

signature.asc (application/pgp-signature, 833 B)