Re: [PATCH v2] Make some standard open() flags visible

Corinna Vinschen <[email protected]> Mon, 18 Feb 2019 15:26:12 +0100

Newsgroups	gmane.comp.lib.newlib
Message-ID	<[email protected]>

On Feb 18 15:22, Corinna Vinschen wrote:
> On Feb 18 14:06, Sebastian Huber wrote:
> > Make the POSIX O_CLOEXEC, O_NOFOLLOW, O_DIRECTORY, O_EXEC, and O_SEARCH
> > open() flags available also to non-Cygwin systems.
> > 
> > Make the BSD/glibc O_DIRECT open() flag  available also to non-Cygwin
> > systems.
> > 
> > Signed-off-by: Sebastian Huber <[email protected]>
> > ---
> >  newlib/libc/include/sys/_default_fcntl.h | 48 ++++++++++++++++++--------------
> >  1 file changed, 27 insertions(+), 21 deletions(-)
> > 
> > diff --git a/newlib/libc/include/sys/_default_fcntl.h b/newlib/libc/include/sys/_default_fcntl.h
> > index 33b462285..22fa10688 100644
> > --- a/newlib/libc/include/sys/_default_fcntl.h
> > +++ b/newlib/libc/include/sys/_default_fcntl.h
> > @@ -23,6 +23,19 @@ extern "C" {
> >  #define	_FNONBLOCK	0x4000	/* non blocking I/O (POSIX style) */
> >  #define	_FNDELAY	_FNONBLOCK	/* non blocking I/O (4.2 style) */
> >  #define	_FNOCTTY	0x8000	/* don't assign a ctty on this open */
> > +#if defined (__CYGWIN__)
> > +#define	_FBINARY	0x10000
> > +#define	_FTEXT		0x20000
> > +#endif
> > +#define	_FNOINHERIT	0x40000
> > +#define	_FDIRECT	0x80000
> > +#define	_FNOFOLLOW	0x100000
> > +#define	_FDIRECTORY	0x200000
> > +#define	_FEXECSRCH	0x400000
> > +#if defined (__CYGWIN__)
> > +#define	_FTMPFILE	0x800000
> > +#define	_FNOATIME	0x1000000
> > +#endif
> 
> This patch looks a bit... outdated?

I missed to read the whole thread before replying, sorry.

The other patches look ok, please push.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

signature.asc (application/pgp-signature, 833 B)